* [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len
@ 2007-10-01 23:02 Dale Farnsworth
2007-10-02 16:55 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Dale Farnsworth @ 2007-10-01 23:02 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
From: Dale Farnsworth <dale@farnsworth.org>
This driver erroneously zeros dev->tx_queue_len, since
mp->tx_ring_size has not yet been initialized. Actually,
the driver shouldn't modify tx_queue_len at all and should
leave the value set by alloc_etherdev(), currently 1000.
Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
---
Jeff, this bug was just reported today, or I would have batched
it with the one I sent you last week. It's an obvious bugfix,
so I'm not going to hold it in my queue.
drivers/net/mv643xx_eth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 34288fe..3153356 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -1357,7 +1357,6 @@ static int mv643xx_eth_probe(struct platform_device *pdev)
#endif
dev->watchdog_timeo = 2 * HZ;
- dev->tx_queue_len = mp->tx_ring_size;
dev->base_addr = 0;
dev->change_mtu = mv643xx_eth_change_mtu;
dev->do_ioctl = mv643xx_eth_do_ioctl;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len
2007-10-01 23:02 [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len Dale Farnsworth
@ 2007-10-02 16:55 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-10-02 16:55 UTC (permalink / raw)
To: Dale Farnsworth; +Cc: netdev
Dale Farnsworth wrote:
> From: Dale Farnsworth <dale@farnsworth.org>
>
> This driver erroneously zeros dev->tx_queue_len, since
> mp->tx_ring_size has not yet been initialized. Actually,
> the driver shouldn't modify tx_queue_len at all and should
> leave the value set by alloc_etherdev(), currently 1000.
>
> Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
> ---
> Jeff, this bug was just reported today, or I would have batched
> it with the one I sent you last week. It's an obvious bugfix,
> so I'm not going to hold it in my queue.
>
> drivers/net/mv643xx_eth.c | 1 -
> 1 file changed, 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-02 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-01 23:02 [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len Dale Farnsworth
2007-10-02 16:55 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).