From: Jeff Garzik <jeff@garzik.org>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: netdev@vger.kernel.org
Subject: Re: [patch] dm9601: Fix receive MTU
Date: Tue, 02 Oct 2007 13:01:29 -0400 [thread overview]
Message-ID: <47027969.8060209@garzik.org> (raw)
In-Reply-To: <87myv35aoo.fsf@macbook.be.48ers.dk>
Peter Korsgaard wrote:
> Please apply to 2.6.23.
> ---
> dm9601 didn't take the ethernet header into account when calculating
> RX MTU, causing packets bigger than 1486 to fail.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> drivers/net/usb/dm9601.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-rc8/drivers/net/usb/dm9601.c
> ===================================================================
> --- linux-2.6.23-rc8.orig/drivers/net/usb/dm9601.c
> +++ linux-2.6.23-rc8/drivers/net/usb/dm9601.c
> @@ -405,7 +405,7 @@
> dev->net->ethtool_ops = &dm9601_ethtool_ops;
> dev->net->hard_header_len += DM_TX_OVERHEAD;
> dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len;
> - dev->rx_urb_size = dev->net->mtu + DM_RX_OVERHEAD;
> + dev->rx_urb_size = dev->net->mtu + ETH_HLEN + DM_RX_OVERHEAD;
applied. in the future, please note (and avoid) a patch formatting
error. As noted in #14 of Documentation/SubmittingPatches, any comments
on the patch like "Please apply to 2.6.23" should go AFTER the patch
description and "---" separator.
Without hand editing, the normal tools everybody uses for importing
patches would delete your "dm9601 didn't take the ethernet header..."
description, leaving only the "Please apply to 2.6.23." part and nothing
else.
I did the hand-editing, but please try to follow the standard patch
format in the future.
next prev parent reply other threads:[~2007-10-02 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 11:36 [patch] dm9601: Fix receive MTU Peter Korsgaard
2007-10-02 17:01 ` Jeff Garzik [this message]
2007-10-02 17:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47027969.8060209@garzik.org \
--to=jeff@garzik.org \
--cc=jacmet@sunsite.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).