* [patch] dm9601: Fix receive MTU
@ 2007-10-01 11:36 Peter Korsgaard
2007-10-02 17:01 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2007-10-01 11:36 UTC (permalink / raw)
To: Jeff Garzik, netdev
Please apply to 2.6.23.
---
dm9601 didn't take the ethernet header into account when calculating
RX MTU, causing packets bigger than 1486 to fail.
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
---
drivers/net/usb/dm9601.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.23-rc8/drivers/net/usb/dm9601.c
===================================================================
--- linux-2.6.23-rc8.orig/drivers/net/usb/dm9601.c
+++ linux-2.6.23-rc8/drivers/net/usb/dm9601.c
@@ -405,7 +405,7 @@
dev->net->ethtool_ops = &dm9601_ethtool_ops;
dev->net->hard_header_len += DM_TX_OVERHEAD;
dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len;
- dev->rx_urb_size = dev->net->mtu + DM_RX_OVERHEAD;
+ dev->rx_urb_size = dev->net->mtu + ETH_HLEN + DM_RX_OVERHEAD;
dev->mii.dev = dev->net;
dev->mii.mdio_read = dm9601_mdio_read;
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] dm9601: Fix receive MTU
2007-10-01 11:36 [patch] dm9601: Fix receive MTU Peter Korsgaard
@ 2007-10-02 17:01 ` Jeff Garzik
2007-10-02 17:40 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-10-02 17:01 UTC (permalink / raw)
To: Peter Korsgaard; +Cc: netdev
Peter Korsgaard wrote:
> Please apply to 2.6.23.
> ---
> dm9601 didn't take the ethernet header into account when calculating
> RX MTU, causing packets bigger than 1486 to fail.
>
> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
> ---
> drivers/net/usb/dm9601.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-rc8/drivers/net/usb/dm9601.c
> ===================================================================
> --- linux-2.6.23-rc8.orig/drivers/net/usb/dm9601.c
> +++ linux-2.6.23-rc8/drivers/net/usb/dm9601.c
> @@ -405,7 +405,7 @@
> dev->net->ethtool_ops = &dm9601_ethtool_ops;
> dev->net->hard_header_len += DM_TX_OVERHEAD;
> dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len;
> - dev->rx_urb_size = dev->net->mtu + DM_RX_OVERHEAD;
> + dev->rx_urb_size = dev->net->mtu + ETH_HLEN + DM_RX_OVERHEAD;
applied. in the future, please note (and avoid) a patch formatting
error. As noted in #14 of Documentation/SubmittingPatches, any comments
on the patch like "Please apply to 2.6.23" should go AFTER the patch
description and "---" separator.
Without hand editing, the normal tools everybody uses for importing
patches would delete your "dm9601 didn't take the ethernet header..."
description, leaving only the "Please apply to 2.6.23." part and nothing
else.
I did the hand-editing, but please try to follow the standard patch
format in the future.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] dm9601: Fix receive MTU
2007-10-02 17:01 ` Jeff Garzik
@ 2007-10-02 17:40 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2007-10-02 17:40 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
>>>>> "Jeff" == Jeff Garzik <jeff@garzik.org> writes:
Hi,
Jeff> applied. in the future, please note (and avoid) a patch formatting
Jeff> error. As noted in #14 of Documentation/SubmittingPatches, any
Jeff> comments on the patch like "Please apply to 2.6.23" should go AFTER
Jeff> the patch description and "---" separator.
Sorry about that - And thanks!
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-02 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-01 11:36 [patch] dm9601: Fix receive MTU Peter Korsgaard
2007-10-02 17:01 ` Jeff Garzik
2007-10-02 17:40 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).