netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: hadi@cyberus.ca
Cc: "Kok, Auke" <auke-jan.h.kok@intel.com>, netdev@vger.kernel.org
Subject: Re: [PATCH][E1000E] some cleanups
Date: Tue, 02 Oct 2007 10:43:45 -0700	[thread overview]
Message-ID: <47028351.7090509@intel.com> (raw)
In-Reply-To: <1191174077.6165.11.camel@localhost>

jamal wrote:
> Auke,
> 
> heres part of something i promised. 
> I couldnt do any packet testing on because 82571EB is disabled in the
> driver. I uncommented the code out in the table, but the best i could
> get was the module loading, some probing and some sysfs renaming
> failures (probably a debianism); the machine access is intermittent, so
> thats as far as i could go. In any case, you probably have a good reason
> for disabling that chip. So, heres the patch, the burden of testing now
> falls on you ;->


the description of this patch is rather misleading, and the title certainly too.
Can you resend this with a bit more elaborate explanation as to why the cb code is
relevant to use here? Not only do I need to understand this, but others might want
to as well later on ;)

Cheers,

Auke

  parent reply	other threads:[~2007-10-02 17:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-30 17:41 [PATCH][E1000E] some cleanups jamal
2007-09-30 18:16 ` Kok, Auke
2007-09-30 19:01   ` jamal
2007-09-30 19:23     ` Jeff Garzik
2007-09-30 19:31       ` jamal
2007-10-01  1:59         ` Kok, Auke
2007-10-02 12:25           ` jamal
2007-10-02 17:06             ` Kok, Auke
2007-10-02 17:43 ` Kok, Auke [this message]
2007-10-03 13:18   ` jamal
2007-10-07 16:15     ` jamal
2007-10-08 22:40       ` Kok, Auke
2007-10-09 13:29         ` jamal
2007-10-09 16:02           ` Kok, Auke
2007-10-09 22:18             ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47028351.7090509@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=hadi@cyberus.ca \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).