From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: pomac@vapor.com, Linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: jumbo frame regression fix
Date: Wed, 03 Oct 2007 00:58:46 -0400 [thread overview]
Message-ID: <47032186.40304@pobox.com> (raw)
In-Reply-To: <20071002215316.0faa7676@freepuppy.rosehill>
Stephen Hemminger wrote:
> On Tue, 02 Oct 2007 21:07:22 -0400
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>> Stephen Hemminger wrote:
>>> Remove unneeded check that caused problems with jumbo frame sizes.
>>> The check was recently added and is wrong.
>>> When using jumbo frames the sky2 driver does fragmentation, so
>>> rx_data_size is less than mtu.
>>>
>>> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>>>
>>> --- a/drivers/net/sky2.c 2007-10-02 17:56:31.000000000 -0700
>>> +++ b/drivers/net/sky2.c 2007-10-02 17:58:56.000000000 -0700
>>> @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru
>>> sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending;
>>> prefetch(sky2->rx_ring + sky2->rx_next);
>>>
>>> - if (length < ETH_ZLEN || length > sky2->rx_data_size)
>>> - goto len_error;
>>> -
>> 2.6.23? 2.6.24? enquiring minds want to know...
>
> 2.6.23, since it is a regression
You can have regressions in behavior in net-2.6.24.git, too. _Please_
be specific about where you want your patches to go. Thanks.
Jeff
next prev parent reply other threads:[~2007-10-03 4:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1191372129.26233.12.camel@localhost>
2007-10-03 1:02 ` [PATCH] sky2: jumbo frame regression fix Stephen Hemminger
2007-10-03 1:07 ` Jeff Garzik
2007-10-03 4:53 ` Stephen Hemminger
2007-10-03 4:58 ` Jeff Garzik [this message]
2007-10-03 1:34 ` Ian Kumlien
2007-10-03 4:59 ` Stephen Hemminger
2007-10-03 7:37 ` Ian Kumlien
2007-10-03 8:29 ` iank
2007-11-24 16:23 ` [SKY2] Problems (2.6.24-rc3-git1) Ian Kumlien
2007-10-03 18:04 ` [PATCH] sky2: jumbo frame regression fix Bill Davidsen
2007-10-03 18:28 ` Ian Kumlien
2007-10-03 17:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47032186.40304@pobox.com \
--to=jgarzik@pobox.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pomac@vapor.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).