From: Tina Yang <tina.yang@oracle.com>
To: Matt Mackall <mpm@selenic.com>, netdev@vger.kernel.org
Subject: netconsole problems
Date: Thu, 04 Oct 2007 10:59:38 -0700 [thread overview]
Message-ID: <47052A0A.2080100@oracle.com> (raw)
We recently run into a few problems with netconsole
in at least 2.6.9, 2.6.18 and 2.6.23. It either panicked
at netdevice.h:890 or hung the system, and sometimes depending
on which NIC we are using, the following console message,
e1000:
"e1000: eth0: e1000_clean_tx_irq: Detected Tx Unit Hang"
tg3:
"NETDEV WATCHDOG: eth4: transmit timed out"
"tg3: eth4: transmit timed out, resetting"
The postmortem vmcore analysis indicated race between normal
network stack (net_rx_action) and netpoll, and disabling the
following code segment cures all the problems.
netpoll.c
178 /* Process pending work on NIC */
179 np->dev->poll_controller(np->dev);
180 if (np->dev->poll)
181 poll_napi(np);
Big or small, there seems to be several race windows in the code,
and fixing them probably has consequence on overall system performance.
Maybe this code should only run when the machine is single-threaded ?
Suggestions ? Thanks.
next reply other threads:[~2007-10-04 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 17:59 Tina Yang [this message]
2007-10-05 0:27 ` netconsole problems Matt Mackall
2007-10-05 1:22 ` Tina Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47052A0A.2080100@oracle.com \
--to=tina.yang@oracle.com \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).