From: "Denis V. Lunev" <dlunev@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: "Denis V. Lunev" <den@openvz.org>,
containers@lists.osdl.org, netdev@vger.kernel.org,
davem@davemloft.net, devel@openvz.org
Subject: Re: [Devel] Re: [PATCH 5/5] make netlink user -> kernel interface synchronious
Date: Fri, 05 Oct 2007 20:56:29 +0400 [thread overview]
Message-ID: <47066CBD.90307@gmail.com> (raw)
In-Reply-To: <4706653B.3050000@trash.net>
Patrick McHardy wrote:
> Denis V. Lunev wrote:
>> This patch make processing netlink user -> kernel messages synchronious.
>> This change was inspired by the talk with Alexey Kuznetsov about current
>> netlink messages processing. He says that he was badly wrong when introduced
>> asynchronious user -> kernel communication.
>>
>> The call netlink_unicast is the only path to send message to the kernel
>> netlink socket. But, unfortunately, it is also used to send data to the
>> user.
>>
>> Before this change the user message has been attached to the socket queue
>> and sk->sk_data_ready was called. The process has been blocked until all
>> pending messages were processed. The bad thing is that this processing
>> may occur in the arbitrary process context.
>>
>> This patch changes nlk->data_ready callback to get 1 skb and force packet
>> processing right in the netlink_unicast.
>
>
> I guess the process credential stuff in netlink_skb_params can now
> be removed as well.
Yes, but I think the patch should be tested by more people before.
Regards,
Den
next prev parent reply other threads:[~2007-10-05 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 14:48 [PATCH 5/5] make netlink user -> kernel interface synchronious Denis V. Lunev
2007-10-05 16:24 ` Patrick McHardy
2007-10-05 16:56 ` Denis V. Lunev [this message]
2007-10-11 4:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47066CBD.90307@gmail.com \
--to=dlunev@gmail.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).