netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: David Miller <davem@davemloft.net>,
	Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH] Evict tmp variable from the stack in ip6_evictor
Date: Wed, 10 Oct 2007 17:06:07 +0200	[thread overview]
Message-ID: <470CEA5F.7050508@trash.net> (raw)
In-Reply-To: <470CE724.8030807@openvz.org>

Pavel Emelyanov wrote:
> Patrick McHardy wrote:
>> Pavel Emelyanov wrote:
>>> The list_head *tmp is used to help getting the first entry in
>>> the ip6_frag_lru_list list. There is a simpler way to do it
>>
>> The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c,
>> please also change it there.
> 
> Hm, indeed. But I see that the structs frag_queue in reassembly.c, ipq 
> in ip_fragment.c and nf_ct_frag6_queue in nf code looks VERY similar 
> and very much of code (like link/unlink or evict) looks the same too.
> 
> Maybe it's worth creating something like struct skb_fragment and
> consolidate all the common stuff into some net/core/lib_frag.c? Or
> is there some hidden reason for keeping this code splitted?


I'm not sure if its possible between IPv4 and IPv6, but sharing code
between IPv6 reassembly and netfilter/ipv6 would be nice.

  reply	other threads:[~2007-10-10 15:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10 14:29 [PATCH] Evict tmp variable from the stack in ip6_evictor Pavel Emelyanov
2007-10-10 14:37 ` Patrick McHardy
2007-10-10 14:52   ` Pavel Emelyanov
2007-10-10 15:06     ` Patrick McHardy [this message]
2007-10-10 23:31       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=470CEA5F.7050508@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).