From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] Evict tmp variable from the stack in ip6_evictor Date: Wed, 10 Oct 2007 17:06:07 +0200 Message-ID: <470CEA5F.7050508@trash.net> References: <470CE1C8.9020000@openvz.org> <470CE38C.2020607@trash.net> <470CE724.8030807@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , Linux Netdev List To: Pavel Emelyanov Return-path: Received: from stinky.trash.net ([213.144.137.162]:63680 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753636AbXJJPGK (ORCPT ); Wed, 10 Oct 2007 11:06:10 -0400 In-Reply-To: <470CE724.8030807@openvz.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Pavel Emelyanov wrote: > Patrick McHardy wrote: >> Pavel Emelyanov wrote: >>> The list_head *tmp is used to help getting the first entry in >>> the ip6_frag_lru_list list. There is a simpler way to do it >> >> The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c, >> please also change it there. > > Hm, indeed. But I see that the structs frag_queue in reassembly.c, ipq > in ip_fragment.c and nf_ct_frag6_queue in nf code looks VERY similar > and very much of code (like link/unlink or evict) looks the same too. > > Maybe it's worth creating something like struct skb_fragment and > consolidate all the common stuff into some net/core/lib_frag.c? Or > is there some hidden reason for keeping this code splitted? I'm not sure if its possible between IPv4 and IPv6, but sharing code between IPv6 reassembly and netfilter/ipv6 would be nice.