From: Brian Haley <brian.haley@hp.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
netdev-owner@vger.kernel.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493
Date: Wed, 10 Oct 2007 17:20:45 -0400 [thread overview]
Message-ID: <470D422D.5070403@hp.com> (raw)
In-Reply-To: <OF75CC6365.1CACD211-ON88257370.0071BBE2-88257370.0071F400@us.ibm.com>
David Stevens wrote:
> What about just checking for 0 in the later test?
>
> if (val && __dev_get_by_index(val) == NULL) {
We could fail the next check right before that though:
if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != val)
goto e_inval;
I just mimicked what the IPv4 code does in do_ip_setsockopt().
-Brian
next prev parent reply other threads:[~2007-10-10 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-10 15:04 [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493 Brian Haley
2007-10-10 20:45 ` David Stevens
2007-10-10 21:20 ` Brian Haley [this message]
2007-10-10 21:48 ` David Stevens
2007-10-10 23:42 ` David Miller
2007-10-11 0:33 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470D422D.5070403@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).