[PATCH] Update function names in /proc/net/tcp documentation

[PATCH] Update function names in /proc/net/tcp documentation

[Jean Delvare]

Update function name references to match the current code.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
 Documentation/networking/proc_net_tcp.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.23.orig/Documentation/networking/proc_net_tcp.txt	2007-02-04 19:44:54.000000000 +0100
+++ linux-2.6.23/Documentation/networking/proc_net_tcp.txt	2007-10-12 22:50:15.000000000 +0200
@@ -1,8 +1,8 @@
 This document describes the interfaces /proc/net/tcp and /proc/net/tcp6.
 
 These /proc interfaces provide information about currently active TCP 
-connections, and are implemented by tcp_get_info() in net/ipv4/tcp_ipv4.c and
-tcp6_get_info() in net/ipv6/tcp_ipv6.c, respectively.
+connections, and are implemented by tcp4_seq_show() in net/ipv4/tcp_ipv4.c
+and tcp6_seq_show() in net/ipv6/tcp_ipv6.c, respectively.
 
 It will first list all listening TCP sockets, and next list all established
 TCP connections. A typical entry of /proc/net/tcp would look like this (split 


-- 
Jean Delvare

Re: [PATCH] Update function names in /proc/net/tcp documentation

[Rick Jones]

Jean Delvare wrote:
> Update function name references to match the current code.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
>  Documentation/networking/proc_net_tcp.txt |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.23.orig/Documentation/networking/proc_net_tcp.txt	2007-02-04 19:44:54.000000000 +0100
> +++ linux-2.6.23/Documentation/networking/proc_net_tcp.txt	2007-10-12 22:50:15.000000000 +0200
> @@ -1,8 +1,8 @@
>  This document describes the interfaces /proc/net/tcp and /proc/net/tcp6.
>  
>  These /proc interfaces provide information about currently active TCP 
> -connections, and are implemented by tcp_get_info() in net/ipv4/tcp_ipv4.c and
> -tcp6_get_info() in net/ipv6/tcp_ipv6.c, respectively.
> +connections, and are implemented by tcp4_seq_show() in net/ipv4/tcp_ipv4.c
> +and tcp6_seq_show() in net/ipv6/tcp_ipv6.c, respectively.
>  
>  It will first list all listening TCP sockets, and next list all established
>  TCP connections. A typical entry of /proc/net/tcp would look like this (split 

/proc/net/[tcp|tcp6] are deprecated now right?  Perhaps there should be 
something to that effect added to the txt.

rick jones

Re: [PATCH] Update function names in /proc/net/tcp documentation

[Jean Delvare]

Hi Rick,

On Fri, 12 Oct 2007 16:13:32 -0700, Rick Jones wrote:
> Jean Delvare wrote:
> > Update function name references to match the current code.
> > 
> > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> > ---
> >  Documentation/networking/proc_net_tcp.txt |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > --- linux-2.6.23.orig/Documentation/networking/proc_net_tcp.txt	2007-02-04 19:44:54.000000000 +0100
> > +++ linux-2.6.23/Documentation/networking/proc_net_tcp.txt	2007-10-12 22:50:15.000000000 +0200
> > @@ -1,8 +1,8 @@
> >  This document describes the interfaces /proc/net/tcp and /proc/net/tcp6.
> >  
> >  These /proc interfaces provide information about currently active TCP 
> > -connections, and are implemented by tcp_get_info() in net/ipv4/tcp_ipv4.c and
> > -tcp6_get_info() in net/ipv6/tcp_ipv6.c, respectively.
> > +connections, and are implemented by tcp4_seq_show() in net/ipv4/tcp_ipv4.c
> > +and tcp6_seq_show() in net/ipv6/tcp_ipv6.c, respectively.
> >  
> >  It will first list all listening TCP sockets, and next list all established
> >  TCP connections. A typical entry of /proc/net/tcp would look like this (split 
> 
> /proc/net/[tcp|tcp6] are deprecated now right?  Perhaps there should be 
> something to that effect added to the txt.

I didn't know that, sorry. What is the new interface to access the
TCP information?

-- 
Jean Delvare

Re: [PATCH] Update function names in /proc/net/tcp documentation

[Herbert Xu]

Jean Delvare <khali@linux-fr.org> wrote:
>
> I didn't know that, sorry. What is the new interface to access the
> TCP information?

inet_diag is the preferred interface.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] Update function names in /proc/net/tcp documentation

[Jean Delvare]

Hi Herbert,

On Sat, 13 Oct 2007 20:49:56 +0800, Herbert Xu wrote:
> Jean Delvare <khali@linux-fr.org> wrote:
> >
> > I didn't know that, sorry. What is the new interface to access the
> > TCP information?
> 
> inet_diag is the preferred interface.

How does it work? Is there some documentation available? I see
net/ipv4/inet_diag.c but I have no idea how to use it.

Thanks,
-- 
Jean Delvare

Re: [PATCH] Update function names in /proc/net/tcp documentation

[Herbert Xu]

Jean Delvare <khali@linux-fr.org> wrote:
>
>> inet_diag is the preferred interface.
> 
> How does it work? Is there some documentation available? I see
> net/ipv4/inet_diag.c but I have no idea how to use it.

Have a look at the iproute package.  It contains the ss command
which provides a command-line interface to it.

Of course it's also a good example of how you can access it from
C.  The Debian pidentd package has also been patched to use this
interface.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] Update function names in /proc/net/tcp documentation

[Jean Delvare]

Hi Herbert,

On Sun, 14 Oct 2007 18:09:12 +0800, Herbert Xu wrote:
> Jean Delvare <khali@linux-fr.org> wrote:
> >
> >> inet_diag is the preferred interface.
> > 
> > How does it work? Is there some documentation available? I see
> > net/ipv4/inet_diag.c but I have no idea how to use it.
> 
> Have a look at the iproute package.  It contains the ss command
> which provides a command-line interface to it.
> 
> Of course it's also a good example of how you can access it from
> C.  The Debian pidentd package has also been patched to use this
> interface.

Thanks for the information. Now I'm worried that most people use
netstat and not ss, while it seems that netstat doesn't have tcp_diag
support. Would it make sense to add tcp_diag support to netstat? Or
should we simply invite system admins to switch from netstat to ss
(maybe by adding a netstat-like formatting option)?

Not that I am skilled enough in this area to do either myself anyway
(let alone the lack of time), but I'm curious what the correct approach
would be.

Thanks,
-- 
Jean Delvare

Re: [PATCH] Update function names in /proc/net/tcp documentation

[Herbert Xu]

On Tue, Oct 16, 2007 at 10:46:36AM +0200, Jean Delvare wrote:
>
> Thanks for the information. Now I'm worried that most people use
> netstat and not ss, while it seems that netstat doesn't have tcp_diag
> support. Would it make sense to add tcp_diag support to netstat? Or
> should we simply invite system admins to switch from netstat to ss
> (maybe by adding a netstat-like formatting option)?

Personally getting netstat to use inet_diag would seem to be
easier than retraining everybody's fingers to type ss :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt