* [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23)
@ 2007-10-12 2:42 Michael Pyne
2007-10-15 18:33 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Michael Pyne @ 2007-10-12 2:42 UTC (permalink / raw)
To: Andrew Morton, Jeff Garzik; +Cc: netdev
Partially revert a change to mac address detection introduced to the forcedeth
driver. The change was intended to correct mac address detection for newer
nVidia chipsets where the mac address was stored in reverse order. One of
those chipsets appears to still have the mac address in reverse order (or at
least, it does on my system).
Signed-off-by: Michael J. Pyne <michael.pyne@kdemail.net>
---
The change that broke mac address detection for my card was commit
ef756b3e56c68a4d76d9d7b9a73fa8f4f739180f "forcedeth: mac address correct"
My network card is an nVidia built-in Ethernet card, output from lspci as
follows (with text and numeric ids):
$ lspci | grep Ethernet
00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2)
$ lspci -n | grep 07.0
00:07.0 0680: 10de:03ef (rev a2)
The vendor id is, of course, nVidia. The device id corresponds to the
NVIDIA_NVENET_19 entry.
The included patch fixes the MAC address detection on my system.
Interestingly, the MAC address appears to be in the range reserved for my
motherboard manufacturer (Gigabyte) and not nVidia.
If you need any further information about my hardware configuration just let
me know.
Regards,
- Michael Pyne
--- a/drivers/net/forcedeth.c 2007-10-11 22:01:26 -0400
+++ b/drivers/net/forcedeth-new.c 2007-10-11 22:06:52 -0400
@@ -5513,7 +5513,7 @@ static struct pci_device_id pci_tbl[] =
},
{ /* MCP61 Ethernet Controller */
PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_19),
- .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR,
+ .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT,
},
{ /* MCP65 Ethernet Controller */
PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_20),
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23)
2007-10-12 2:42 [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23) Michael Pyne
@ 2007-10-15 18:33 ` Jeff Garzik
2007-10-14 21:57 ` Ayaz Abdulla
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-10-15 18:33 UTC (permalink / raw)
To: Ayaz Abdulla; +Cc: Michael Pyne, Andrew Morton, netdev
Michael Pyne wrote:
> Partially revert a change to mac address detection introduced to the forcedeth
> driver. The change was intended to correct mac address detection for newer
> nVidia chipsets where the mac address was stored in reverse order. One of
> those chipsets appears to still have the mac address in reverse order (or at
> least, it does on my system).
>
> Signed-off-by: Michael J. Pyne <michael.pyne@kdemail.net>
> ---
> The change that broke mac address detection for my card was commit
> ef756b3e56c68a4d76d9d7b9a73fa8f4f739180f "forcedeth: mac address correct"
>
> My network card is an nVidia built-in Ethernet card, output from lspci as
> follows (with text and numeric ids):
> $ lspci | grep Ethernet
> 00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2)
> $ lspci -n | grep 07.0
> 00:07.0 0680: 10de:03ef (rev a2)
>
> The vendor id is, of course, nVidia. The device id corresponds to the
> NVIDIA_NVENET_19 entry.
>
> The included patch fixes the MAC address detection on my system.
> Interestingly, the MAC address appears to be in the range reserved for my
> motherboard manufacturer (Gigabyte) and not nVidia.
>
> If you need any further information about my hardware configuration just let
> me know.
>
> Regards,
> - Michael Pyne
>
> --- a/drivers/net/forcedeth.c 2007-10-11 22:01:26 -0400
> +++ b/drivers/net/forcedeth-new.c 2007-10-11 22:06:52 -0400
> @@ -5513,7 +5513,7 @@ static struct pci_device_id pci_tbl[] =
> },
> { /* MCP61 Ethernet Controller */
> PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_19),
> - .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
> DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
> DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR,
> + .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
> DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
> DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT,
> },
> { /* MCP65 Ethernet Controller */
> PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_20),
your patch is word-wrapped. Anyway...
Ayaz -- ACK this patch?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23)
2007-10-15 18:33 ` Jeff Garzik
@ 2007-10-14 21:57 ` Ayaz Abdulla
0 siblings, 0 replies; 3+ messages in thread
From: Ayaz Abdulla @ 2007-10-14 21:57 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Michael Pyne, Andrew Morton, netdev
Jeff Garzik wrote:
> Michael Pyne wrote:
>
>> Partially revert a change to mac address detection introduced to the
>> forcedeth driver. The change was intended to correct mac address
>> detection for newer nVidia chipsets where the mac address was stored
>> in reverse order. One of those chipsets appears to still have the mac
>> address in reverse order (or at least, it does on my system).
>>
>> Signed-off-by: Michael J. Pyne <michael.pyne@kdemail.net>
>> ---
>> The change that broke mac address detection for my card was commit
>> ef756b3e56c68a4d76d9d7b9a73fa8f4f739180f "forcedeth: mac address correct"
>>
>> My network card is an nVidia built-in Ethernet card, output from lspci
>> as follows (with text and numeric ids):
>> $ lspci | grep Ethernet
>> 00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2)
>> $ lspci -n | grep 07.0
>> 00:07.0 0680: 10de:03ef (rev a2)
>>
>> The vendor id is, of course, nVidia. The device id corresponds to the
>> NVIDIA_NVENET_19 entry.
>>
>> The included patch fixes the MAC address detection on my system.
>> Interestingly, the MAC address appears to be in the range reserved for
>> my motherboard manufacturer (Gigabyte) and not nVidia.
>>
>> If you need any further information about my hardware configuration
>> just let me know.
>>
>> Regards,
>> - Michael Pyne
>>
>> --- a/drivers/net/forcedeth.c 2007-10-11 22:01:26 -0400
>> +++ b/drivers/net/forcedeth-new.c 2007-10-11 22:06:52 -0400
>> @@ -5513,7 +5513,7 @@ static struct pci_device_id pci_tbl[] = },
>> { /* MCP61 Ethernet Controller */
>> PCI_DEVICE(PCI_VENDOR_ID_NVIDIA,
>> PCI_DEVICE_ID_NVIDIA_NVENET_19),
>> - .driver_data =
>> DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
>> DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
>>
>> DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR,
>> + .driver_data =
>> DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
>> DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
>>
>> DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT,
>> },
>> { /* MCP65 Ethernet Controller */
>> PCI_DEVICE(PCI_VENDOR_ID_NVIDIA,
>> PCI_DEVICE_ID_NVIDIA_NVENET_20),
>
>
> your patch is word-wrapped. Anyway...
>
> Ayaz -- ACK this patch?
ASUS should be contacted to fix their SBIOS instead of patching the driver.
MCP61 reference has the correct address programmed by SBIOS. There are
other vendor boards that will have correct address (as defined by MCP61
reference).
>
>
>
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-15 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-12 2:42 [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23) Michael Pyne
2007-10-15 18:33 ` Jeff Garzik
2007-10-14 21:57 ` Ayaz Abdulla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).