From: Jeff Garzik <jgarzik@pobox.com>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Michael Pyne <michael.pyne@kdemail.net>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23)
Date: Mon, 15 Oct 2007 14:33:21 -0400 [thread overview]
Message-ID: <4713B271.9010607@pobox.com> (raw)
In-Reply-To: <200710112242.50167.michael.pyne@kdemail.net>
Michael Pyne wrote:
> Partially revert a change to mac address detection introduced to the forcedeth
> driver. The change was intended to correct mac address detection for newer
> nVidia chipsets where the mac address was stored in reverse order. One of
> those chipsets appears to still have the mac address in reverse order (or at
> least, it does on my system).
>
> Signed-off-by: Michael J. Pyne <michael.pyne@kdemail.net>
> ---
> The change that broke mac address detection for my card was commit
> ef756b3e56c68a4d76d9d7b9a73fa8f4f739180f "forcedeth: mac address correct"
>
> My network card is an nVidia built-in Ethernet card, output from lspci as
> follows (with text and numeric ids):
> $ lspci | grep Ethernet
> 00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2)
> $ lspci -n | grep 07.0
> 00:07.0 0680: 10de:03ef (rev a2)
>
> The vendor id is, of course, nVidia. The device id corresponds to the
> NVIDIA_NVENET_19 entry.
>
> The included patch fixes the MAC address detection on my system.
> Interestingly, the MAC address appears to be in the range reserved for my
> motherboard manufacturer (Gigabyte) and not nVidia.
>
> If you need any further information about my hardware configuration just let
> me know.
>
> Regards,
> - Michael Pyne
>
> --- a/drivers/net/forcedeth.c 2007-10-11 22:01:26 -0400
> +++ b/drivers/net/forcedeth-new.c 2007-10-11 22:06:52 -0400
> @@ -5513,7 +5513,7 @@ static struct pci_device_id pci_tbl[] =
> },
> { /* MCP61 Ethernet Controller */
> PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_19),
> - .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
> DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
> DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR,
> + .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|
> DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX|DEV_HAS_STATISTICS_V2|
> DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT,
> },
> { /* MCP65 Ethernet Controller */
> PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_20),
your patch is word-wrapped. Anyway...
Ayaz -- ACK this patch?
next prev parent reply other threads:[~2007-10-15 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 2:42 [PATCH] forcedeth: Fix MAC address detection on network card (regression in 2.6.23) Michael Pyne
2007-10-15 18:33 ` Jeff Garzik [this message]
2007-10-14 21:57 ` Ayaz Abdulla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4713B271.9010607@pobox.com \
--to=jgarzik@pobox.com \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=michael.pyne@kdemail.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).