Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

[Joachim Fenkes]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1671 bytes --]

On Tuesday 09 October 2007 10:21, Jan-Bernd Themann wrote:
> Roland Dreier <rdreier@cisco.com> wrote on 03.10.2007 20:05:44:
> >  > > Replace struct ibmebus_dev and struct ibmebus_driver with struct 
of_device
> >  > > and struct of_platform_driver, respectively. Match the external 
ibmebus
> >  > > interface and drivers using it.
> >  > >
> >  > > Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
> >  >
> >  > This is somewhat difficult as this patch touches files that are the
> >  > responsibility of three different maintainers.  Is it possible to
> >  > split the patch into three, one for each maintainer (possibly by
> >  > keeping both old and new interfaces around for a little while)?
> >  > 
> >  > If not, then you need to get an Acked-by and an agreement that this
> >  > change can go via the powerpc.git tree from Roland Dreier and Jeff
> >  > Garzik.
> >
> > I don't see anything objectionable in the infiniband parts of the
> > patch -- I don't have any way to test the changes but it all looks
> > like a straightforward conversion to a new platform API.  So:
> >
> > Acked-by: Roland Dreier <rolandd@cisco.com>
> >
> >  - R.
>
> Looks good from eHEA driver perspective.
>
> Acked-by: Jan-Bernd Themann <themann@de.ibm.com>

Jeff, do you have any objections against this patch going into the kernel
via Paul's powerpc.git tree? It touches only a few lines of ehea which are
specific to the bus interface changes.

You can see the full patch here:
  http://patchwork.ozlabs.org/linuxppc/patch?id=13750

If you have no objections, please ack the patch so Paul can include it.

Thanks and regards,
  Joachim

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

[Jeff Garzik]

Joachim Fenkes wrote:
> On Tuesday 09 October 2007 10:21, Jan-Bernd Themann wrote:
>> Roland Dreier <rdreier@cisco.com> wrote on 03.10.2007 20:05:44:
>>>  > > Replace struct ibmebus_dev and struct ibmebus_driver with struct 
> of_device
>>>  > > and struct of_platform_driver, respectively. Match the external 
> ibmebus
>>>  > > interface and drivers using it.
>>>  > >
>>>  > > Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com>
>>>  >
>>>  > This is somewhat difficult as this patch touches files that are the
>>>  > responsibility of three different maintainers. �Is it possible to
>>>  > split the patch into three, one for each maintainer (possibly by
>>>  > keeping both old and new interfaces around for a little while)?
>>>  > 
>>>  > If not, then you need to get an Acked-by and an agreement that this
>>>  > change can go via the powerpc.git tree from Roland Dreier and Jeff
>>>  > Garzik.
>>>
>>> I don't see anything objectionable in the infiniband parts of the
>>> patch -- I don't have any way to test the changes but it all looks
>>> like a straightforward conversion to a new platform API.  So:
>>>
>>> Acked-by: Roland Dreier <rolandd@cisco.com>
>>>
>>>  - R.
>> Looks good from eHEA driver perspective.
>>
>> Acked-by: Jan-Bernd Themann <themann@de.ibm.com>
> 
> Jeff, do you have any objections against this patch going into the kernel
> via Paul's powerpc.git tree? It touches only a few lines of ehea which are
> specific to the bus interface changes.
> 
> You can see the full patch here:
>   http://patchwork.ozlabs.org/linuxppc/patch?id=13750
> 
> If you have no objections, please ack the patch so Paul can include it.

Fine with me...

	Jeff

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

On Tue, 16 Oct 2007 23:20:00 +0200 Joachim Fenkes <fenkes@de.ibm.com> wrote:
>

One small change - I intend to remove the name and owner fields from
struct of_platform_driver, so you should not bother initialising the name
field and just initialise the name field of the embedded struct
device_driver instead.  This, of course, means that you don't need

	drv->driver.name = drv->name;

in ibmebus_register_driver.

Sorry for not picking this up earlier.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH 4/5] ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA drivers

[Joachim Fenkes]

On Tuesday 16 October 2007 17:27, Stephen Rothwell wrote:

> One small change - I intend to remove the name and owner fields from
> struct of_platform_driver, so you should not bother initialising the name
> field and just initialise the name field of the embedded struct
> device_driver instead.  This, of course, means that you don't need
> 
> 	drv->driver.name = drv->name;
> 
> in ibmebus_register_driver.

I'd prefer to let this line stay in place until you actually make your
change, to keep the data structures consistent as long as the name field is
present. You could remove it in your patch then.

Regards,
  Joachim