* [PATCH] Fix memory leak in cleanup_ipv6_mibs()
@ 2007-10-17 14:04 Pavel Emelyanov
2007-10-17 16:23 ` David Stevens
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Emelyanov @ 2007-10-17 14:04 UTC (permalink / raw)
To: David Miller; +Cc: Linux Netdev List, devel
The icmpv6msg mib statistics is not freed.
This is almost not critical for current kernel, since ipv6
module is unloadable, but this can happen on load error and
will happen every time we stop the network namespace (when
we have one, of course).
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
index bc92938..1b1caf3 100644
--- a/net/ipv6/af_inet6.c
+++ b/net/ipv6/af_inet6.c
@@ -747,6 +747,7 @@ static void cleanup_ipv6_mibs(void)
{
snmp_mib_free((void **)ipv6_statistics);
snmp_mib_free((void **)icmpv6_statistics);
+ snmp_mib_free((void **)icmpv6msg_statistics);
snmp_mib_free((void **)udp_stats_in6);
snmp_mib_free((void **)udplite_stats_in6);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix memory leak in cleanup_ipv6_mibs()
2007-10-17 14:04 [PATCH] Fix memory leak in cleanup_ipv6_mibs() Pavel Emelyanov
@ 2007-10-17 16:23 ` David Stevens
2007-10-18 2:30 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Stevens @ 2007-10-17 16:23 UTC (permalink / raw)
To: Pavel Emelyanov; +Cc: David Miller, devel, Linux Netdev List, netdev-owner
Acked-by: David L Stevens <dlstevens@us.ibm.com>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> ---
>
> diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
> index bc92938..1b1caf3 100644
> --- a/net/ipv6/af_inet6.c
> +++ b/net/ipv6/af_inet6.c
> @@ -747,6 +747,7 @@ static void cleanup_ipv6_mibs(void)
> {
> snmp_mib_free((void **)ipv6_statistics);
> snmp_mib_free((void **)icmpv6_statistics);
> + snmp_mib_free((void **)icmpv6msg_statistics);
> snmp_mib_free((void **)udp_stats_in6);
> snmp_mib_free((void **)udplite_stats_in6);
> }
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix memory leak in cleanup_ipv6_mibs()
2007-10-17 16:23 ` David Stevens
@ 2007-10-18 2:30 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-18 2:30 UTC (permalink / raw)
To: dlstevens; +Cc: xemul, devel, netdev, netdev-owner
From: David Stevens <dlstevens@us.ibm.com>
Date: Wed, 17 Oct 2007 09:23:39 -0700
> Acked-by: David L Stevens <dlstevens@us.ibm.com>
>
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-18 2:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-17 14:04 [PATCH] Fix memory leak in cleanup_ipv6_mibs() Pavel Emelyanov
2007-10-17 16:23 ` David Stevens
2007-10-18 2:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).