* [PATCH] Fix again the fl6_sock_lookup() fixed locking
@ 2007-10-18 12:36 Pavel Emelyanov
2007-10-18 12:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2007-10-18 12:36 UTC (permalink / raw)
To: David Miller; +Cc: Linux Netdev List, devel, YOSHIFUJI Hideaki
YOSHIFUJI fairly pointed out, that the users increment should
be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a
chance to put this count to zero and release the flowlabel.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
---
diff --git a/net/ipv6/ip6_flowlabel.c b/net/ipv6/ip6_flowlabel.c
index e55ae1a..b12cc22 100644
--- a/net/ipv6/ip6_flowlabel.c
+++ b/net/ipv6/ip6_flowlabel.c
@@ -210,9 +210,9 @@ struct ip6_flowlabel * fl6_sock_lookup(struct sock *sk, __be32 label)
for (sfl=np->ipv6_fl_list; sfl; sfl = sfl->next) {
struct ip6_flowlabel *fl = sfl->fl;
if (fl->label == label) {
- read_unlock_bh(&ip6_sk_fl_lock);
fl->lastuse = jiffies;
atomic_inc(&fl->users);
+ read_unlock_bh(&ip6_sk_fl_lock);
return fl;
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix again the fl6_sock_lookup() fixed locking
2007-10-18 12:36 [PATCH] Fix again the fl6_sock_lookup() fixed locking Pavel Emelyanov
@ 2007-10-18 12:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-10-18 12:38 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel, yoshfuji
From: Pavel Emelyanov <xemul@openvz.org>
Date: Thu, 18 Oct 2007 16:36:58 +0400
> YOSHIFUJI fairly pointed out, that the users increment should
> be done under the ip6_sk_fl_lock not to give IPV6_FL_A_PUT a
> chance to put this count to zero and release the flowlabel.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied, thank you very much Pavel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-18 12:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-18 12:36 [PATCH] Fix again the fl6_sock_lookup() fixed locking Pavel Emelyanov
2007-10-18 12:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).