From mboxrd@z Thu Jan 1 00:00:00 1970 From: Valentine Barshak Subject: Re: [PATCH] USB: net: Fix asix read transfer buffer allocations. Date: Mon, 22 Oct 2007 23:22:59 +0400 Message-ID: <471CF893.3050605@ru.mvista.com> References: <20071022155053.GA28526@ru.mvista.com> <200710221929.04035.oliver@neukum.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-usb-devel@lists.sourceforge.net To: Oliver Neukum Return-path: In-Reply-To: <200710221929.04035.oliver@neukum.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-usb-devel-bounces@lists.sourceforge.net Errors-To: linux-usb-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org Oliver Neukum wrote: > Am Montag 22 Oktober 2007 schrieb Valentine Barshak: >> static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc) >> { >> struct usbnet *dev = netdev_priv(netdev); >> + void *buf; >> u16 res; >> >> mutex_lock(&dev->phy_mutex); >> asix_set_sw_mii(dev); >> + >> + buf = kmalloc(2, GFP_KERNEL); > > This is done under lock. Can you allocate the buffer once and reuse it? > > Regards > Oliver > I think we can use 2 bytes of the usbnet data buffer for this. I'll submit a new patch soon. Thanks, Valentine. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ linux-usb-devel@lists.sourceforge.net To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel