From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: netdev@vger.kernel.org, peter.p.waskiewicz.jr@intel.com,
Pavel Emelyanov <xemul@openvz.org>
Subject: Re: sch_prio.c vs CONFIG_NETDEVICES_MULTIQUEUE
Date: Tue, 23 Oct 2007 14:17:36 +0200 [thread overview]
Message-ID: <471DE660.4090004@trash.net> (raw)
In-Reply-To: <20071023121420.GB6267@localhost.sw.ru>
CCed Pavel
Alexey Dobriyan wrote:
> gcc spits following warnings
>
> net/sched/sch_prio.c:139: warning: passing argument 2 of 'netif_subqueue_stopped' makes pointer from integer without a cast
> net/sched/sch_prio.c:169: warning: passing argument 2 of 'netif_subqueue_stopped' makes pointer from integer without a cast
>
> and he is dead right -- passing integer instead of skb is not going to
> work:
>
> if (!netif_subqueue_stopped(sch->dev, (q->mq ? prio : 0))) {
>
> skb_get_queue_mapping will ignore it if multiqueue support is off and
> dereference it otherwise.
next prev parent reply other threads:[~2007-10-23 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 12:14 sch_prio.c vs CONFIG_NETDEVICES_MULTIQUEUE Alexey Dobriyan
2007-10-23 12:17 ` Patrick McHardy [this message]
2007-10-23 13:01 ` Pavel Emelyanov
2007-10-24 3:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471DE660.4090004@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@sw.ru \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).