netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@sw.ru>
To: Thomas Graf <tgraf@suug.ch>
Cc: Dan Williams <dcbw@redhat.com>,
	netdev@vger.kernel.org, "Denis V. Lunev" <den@openvz.org>,
	"David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: Regression in current git - Network Manager fails (bisected)
Date: Tue, 23 Oct 2007 17:09:33 +0400	[thread overview]
Message-ID: <471DF28D.3030904@sw.ru> (raw)
In-Reply-To: <20071023121123.GA8125@postel.suug.ch>

Thomas Graf wrote:
> * Dan Williams <dcbw@redhat.com> 2007-10-22 11:57
>> On Mon, 2007-10-22 at 13:22 +0400, Denis V. Lunev wrote:
>>> We have spent some time with the problem with Alexey and there are no 
>>> guesses for now.
>>>
>>> Is it possible to name exact version of Network Manager and all 
>>> libraries related + provide us an output of strace with full buffers 
>>> send/received from netlink. Something like
>>>      strace -v -x -s 32768 <nm>
>> NM uses netlink in two places; libnl (from Thomas Graf) and some custom
>> code for listening for interface up/down events and wireless events.
>>
>> It looks like that code comes from libnl's lib/handlers.c where it
>> thinks the received message is invalid.
>>
>> I'm pretty sure the code that checks carrier status of the device isn't
>> libnl code; so maybe the error message (which should get fixed of
>> course) isn't in the same path as the link detection.
>>
>> The link detection comes from src/nm-netlink-monitor.c, so maybe we
>> should look at debugging there.
> 
> The patch introduced a change in semantics because it removed the
> special ACK handling after a dump was started.
> 
> I will look into this.
> 

I have reproduced the problem with one-line test.
     ./nl-route-get 192.168.1.1
The problem is with this message:

-- Debug: Sent Message:
--------------------------   BEGIN NETLINK MESSAGE 
---------------------------
   [HEADER] 16 octets
     .nlmsg_len = 20
     .nlmsg_type = 18 <route/link>
     .nlmsg_flags = 773 <REQUEST,ACK,ROOT,MATCH>
     .nlmsg_seq = 1193143772
     .nlmsg_pid = 8233
   [PAYLOAD] 16 octets
     00 1d fa 20 00 00 00 00 81 0e 02 00 00 00 00 00       ... ............
---------------------------  END NETLINK MESSAGE 
---------------------------
it starts dump and requests ACK.

Regards,
	Den

  reply	other threads:[~2007-10-23 13:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22  0:58 Regression in current git - Network Manager fails (bisected) Joseph Fannin
2007-10-22  9:22 ` Denis V. Lunev
2007-10-22 15:57   ` Dan Williams
2007-10-23 12:11     ` Thomas Graf
2007-10-23 13:09       ` Denis V. Lunev [this message]
2007-10-23 13:38         ` Thomas Graf
2007-10-23 14:10           ` Dan Williams
2007-10-25  9:06             ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471DF28D.3030904@sw.ru \
    --to=den@sw.ru \
    --cc=davem@davemloft.net \
    --cc=dcbw@redhat.com \
    --cc=den@openvz.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).