From: Patrick McHardy <kaber@trash.net>
To: Andreas Henriksson <andreas@fatal.se>
Cc: maximilian attems <max@stro.at>,
shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: iproute2: git pull request from debian repo.
Date: Tue, 23 Oct 2007 17:08:10 +0200 [thread overview]
Message-ID: <471E0E5A.40306@trash.net> (raw)
In-Reply-To: <20071023150154.GA25314@scream.fatal.se>
Andreas Henriksson wrote:
> On Tue, Oct 23, 2007 at 04:38:06PM +0200, Patrick McHardy wrote:
>> Almost - the default behaviour shouldn't change IMO. Also please
>> send a complete patch, not one on top of your old one.
>
> Which "default behaviour"? ip addr flush or ip neigh flush behaviour?
> Both of those should behave the same IMHO.
In both cases your changed behaviour should be optional and it should
default to the old behaviour. Not actually flushing completely when the
user specified "flush" is counter-intuitive.
> Defaulting to never bail out is causing problems in a bunch of firewalling
> frontends which has been reported multiple times to both debian and ubuntu
> (and possibly others I don't know about), and looping forever causes the
> bootup to never finish.
> Thats my reason for advocating not selecting the "loop forever" as the
> default choice.
Then those frontends should add "maxrounds N" if they want to abort
before the flush is complete.
next prev parent reply other threads:[~2007-10-23 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 12:27 iproute2: git pull request from debian repo Andreas Henriksson
2007-10-19 13:06 ` maximilian attems
2007-10-19 14:48 ` Andreas Henriksson
2007-10-21 17:48 ` Patrick McHardy
2007-10-23 13:56 ` Andreas Henriksson
2007-10-23 14:18 ` Andreas Henriksson
2007-10-23 14:38 ` Patrick McHardy
2007-10-23 15:01 ` Andreas Henriksson
2007-10-23 15:08 ` Patrick McHardy [this message]
2007-10-23 15:27 ` Andreas Henriksson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471E0E5A.40306@trash.net \
--to=kaber@trash.net \
--cc=andreas@fatal.se \
--cc=max@stro.at \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).