From: Chuck Lever <chuck.lever@oracle.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Tom Talpey <tmt@netapp.com>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static
Date: Wed, 24 Oct 2007 14:41:15 -0400 [thread overview]
Message-ID: <471F91CB.1020607@oracle.com> (raw)
In-Reply-To: <20071024162402.GB30533@stusta.de>
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
Adrian Bunk wrote:
> xs_setup_{udp,tcp}() can now become static.
ACK. Sorry this was overlooked.
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> include/linux/sunrpc/xprtsock.h | 6 ------
> net/sunrpc/xprtsock.c | 4 ++--
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
> 833a31c8caef70589f33be8e3a1fc9d8e01ce3c2
> diff --git a/include/linux/sunrpc/xprtsock.h b/include/linux/sunrpc/xprtsock.h
> index 2c6c2c2..c2a46c4 100644
> --- a/include/linux/sunrpc/xprtsock.h
> +++ b/include/linux/sunrpc/xprtsock.h
> @@ -9,12 +9,6 @@
>
> #ifdef __KERNEL__
>
> -/*
> - * Socket transport setup operations
> - */
> -struct rpc_xprt *xs_setup_udp(struct xprt_create *args);
> -struct rpc_xprt *xs_setup_tcp(struct xprt_create *args);
> -
> int init_socket_xprt(void);
> void cleanup_socket_xprt(void);
>
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 02298f5..2f630a5 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -1828,7 +1828,7 @@ static struct rpc_xprt *xs_setup_xprt(struct xprt_create *args,
> * @args: rpc transport creation arguments
> *
> */
> -struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
> +static struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
> {
> struct sockaddr *addr = args->dstaddr;
> struct rpc_xprt *xprt;
> @@ -1894,7 +1894,7 @@ struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
> * @args: rpc transport creation arguments
> *
> */
> -struct rpc_xprt *xs_setup_tcp(struct xprt_create *args)
> +static struct rpc_xprt *xs_setup_tcp(struct xprt_create *args)
> {
> struct sockaddr *addr = args->dstaddr;
> struct rpc_xprt *xprt;
>
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 327 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
email;internet:chuck dot lever at nospam oracle dot com
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard
prev parent reply other threads:[~2007-10-24 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:24 [2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static Adrian Bunk
2007-10-24 18:41 ` Chuck Lever [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471F91CB.1020607@oracle.com \
--to=chuck.lever@oracle.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tmt@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).