* [2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static
@ 2007-10-24 16:24 Adrian Bunk
2007-10-24 18:41 ` Chuck Lever
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-10-24 16:24 UTC (permalink / raw)
To: Chuck Lever, Tom Talpey, Trond Myklebust; +Cc: netdev, linux-kernel
xs_setup_{udp,tcp}() can now become static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
include/linux/sunrpc/xprtsock.h | 6 ------
net/sunrpc/xprtsock.c | 4 ++--
2 files changed, 2 insertions(+), 8 deletions(-)
833a31c8caef70589f33be8e3a1fc9d8e01ce3c2
diff --git a/include/linux/sunrpc/xprtsock.h b/include/linux/sunrpc/xprtsock.h
index 2c6c2c2..c2a46c4 100644
--- a/include/linux/sunrpc/xprtsock.h
+++ b/include/linux/sunrpc/xprtsock.h
@@ -9,12 +9,6 @@
#ifdef __KERNEL__
-/*
- * Socket transport setup operations
- */
-struct rpc_xprt *xs_setup_udp(struct xprt_create *args);
-struct rpc_xprt *xs_setup_tcp(struct xprt_create *args);
-
int init_socket_xprt(void);
void cleanup_socket_xprt(void);
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 02298f5..2f630a5 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -1828,7 +1828,7 @@ static struct rpc_xprt *xs_setup_xprt(struct xprt_create *args,
* @args: rpc transport creation arguments
*
*/
-struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
+static struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
{
struct sockaddr *addr = args->dstaddr;
struct rpc_xprt *xprt;
@@ -1894,7 +1894,7 @@ struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
* @args: rpc transport creation arguments
*
*/
-struct rpc_xprt *xs_setup_tcp(struct xprt_create *args)
+static struct rpc_xprt *xs_setup_tcp(struct xprt_create *args)
{
struct sockaddr *addr = args->dstaddr;
struct rpc_xprt *xprt;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static
2007-10-24 16:24 [2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static Adrian Bunk
@ 2007-10-24 18:41 ` Chuck Lever
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever @ 2007-10-24 18:41 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Tom Talpey, Trond Myklebust, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]
Adrian Bunk wrote:
> xs_setup_{udp,tcp}() can now become static.
ACK. Sorry this was overlooked.
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> include/linux/sunrpc/xprtsock.h | 6 ------
> net/sunrpc/xprtsock.c | 4 ++--
> 2 files changed, 2 insertions(+), 8 deletions(-)
>
> 833a31c8caef70589f33be8e3a1fc9d8e01ce3c2
> diff --git a/include/linux/sunrpc/xprtsock.h b/include/linux/sunrpc/xprtsock.h
> index 2c6c2c2..c2a46c4 100644
> --- a/include/linux/sunrpc/xprtsock.h
> +++ b/include/linux/sunrpc/xprtsock.h
> @@ -9,12 +9,6 @@
>
> #ifdef __KERNEL__
>
> -/*
> - * Socket transport setup operations
> - */
> -struct rpc_xprt *xs_setup_udp(struct xprt_create *args);
> -struct rpc_xprt *xs_setup_tcp(struct xprt_create *args);
> -
> int init_socket_xprt(void);
> void cleanup_socket_xprt(void);
>
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 02298f5..2f630a5 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -1828,7 +1828,7 @@ static struct rpc_xprt *xs_setup_xprt(struct xprt_create *args,
> * @args: rpc transport creation arguments
> *
> */
> -struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
> +static struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
> {
> struct sockaddr *addr = args->dstaddr;
> struct rpc_xprt *xprt;
> @@ -1894,7 +1894,7 @@ struct rpc_xprt *xs_setup_udp(struct xprt_create *args)
> * @args: rpc transport creation arguments
> *
> */
> -struct rpc_xprt *xs_setup_tcp(struct xprt_create *args)
> +static struct rpc_xprt *xs_setup_tcp(struct xprt_create *args)
> {
> struct sockaddr *addr = args->dstaddr;
> struct rpc_xprt *xprt;
>
[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 327 bytes --]
begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
email;internet:chuck dot lever at nospam oracle dot com
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-24 18:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-24 16:24 [2.6 patch] make sunrpc/xprtsock.c:xs_setup_{udp,tcp}() static Adrian Bunk
2007-10-24 18:41 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).