* [2.6 patch] net/sctp/auth.c: make 3 functions static
@ 2007-10-24 16:24 Adrian Bunk
2007-10-24 20:27 ` Vlad Yasevich
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-10-24 16:24 UTC (permalink / raw)
To: Vlad Yasevich, sri; +Cc: lksctp-developers, linux-kernel, netdev
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
include/net/sctp/auth.h | 1 -
net/sctp/auth.c | 6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
102a72ca5278d3c502bee6af4c4d11c9876d5a2d
diff --git a/include/net/sctp/auth.h b/include/net/sctp/auth.h
index 4945954..9e8f13b 100644
--- a/include/net/sctp/auth.h
+++ b/include/net/sctp/auth.h
@@ -88,7 +88,6 @@ static inline void sctp_auth_key_hold(struct sctp_auth_bytes *key)
void sctp_auth_key_put(struct sctp_auth_bytes *key);
struct sctp_shared_key *sctp_auth_shkey_create(__u16 key_id, gfp_t gfp);
-void sctp_auth_shkey_free(struct sctp_shared_key *sh_key);
void sctp_auth_destroy_keys(struct list_head *keys);
int sctp_auth_asoc_init_active_key(struct sctp_association *asoc, gfp_t gfp);
struct sctp_shared_key *sctp_auth_get_shkey(
diff --git a/net/sctp/auth.c b/net/sctp/auth.c
index 7818107..5a2dd38 100644
--- a/net/sctp/auth.c
+++ b/net/sctp/auth.c
@@ -107,7 +107,7 @@ struct sctp_shared_key *sctp_auth_shkey_create(__u16 key_id, gfp_t gfp)
}
/* Free the shared key stucture */
-void sctp_auth_shkey_free(struct sctp_shared_key *sh_key)
+static void sctp_auth_shkey_free(struct sctp_shared_key *sh_key)
{
BUG_ON(!list_empty(&sh_key->key_list));
sctp_auth_key_put(sh_key->key);
@@ -220,7 +220,7 @@ static struct sctp_auth_bytes *sctp_auth_make_key_vector(
/* Make a key vector based on our local parameters */
-struct sctp_auth_bytes *sctp_auth_make_local_vector(
+static struct sctp_auth_bytes *sctp_auth_make_local_vector(
const struct sctp_association *asoc,
gfp_t gfp)
{
@@ -232,7 +232,7 @@ struct sctp_auth_bytes *sctp_auth_make_local_vector(
}
/* Make a key vector based on peer's parameters */
-struct sctp_auth_bytes *sctp_auth_make_peer_vector(
+static struct sctp_auth_bytes *sctp_auth_make_peer_vector(
const struct sctp_association *asoc,
gfp_t gfp)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [2.6 patch] net/sctp/auth.c: make 3 functions static
2007-10-24 16:24 [2.6 patch] net/sctp/auth.c: make 3 functions static Adrian Bunk
@ 2007-10-24 20:27 ` Vlad Yasevich
2007-10-26 11:21 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Vlad Yasevich @ 2007-10-24 20:27 UTC (permalink / raw)
To: Adrian Bunk; +Cc: sri, lksctp-developers, linux-kernel, netdev
Adrian Bunk wrote:
> This patch makes three needlessly global functions static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
ACK. Thanks for catching these..
-vlad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] net/sctp/auth.c: make 3 functions static
2007-10-24 20:27 ` Vlad Yasevich
@ 2007-10-26 11:21 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-26 11:21 UTC (permalink / raw)
To: vladislav.yasevich; +Cc: bunk, sri, lksctp-developers, linux-kernel, netdev
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Wed, 24 Oct 2007 16:27:38 -0400
> Adrian Bunk wrote:
> > This patch makes three needlessly global functions static.
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ACK. Thanks for catching these..
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-26 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-24 16:24 [2.6 patch] net/sctp/auth.c: make 3 functions static Adrian Bunk
2007-10-24 20:27 ` Vlad Yasevich
2007-10-26 11:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).