From: David Ahern <dsahern@gmail.com>
To: Jeff Barnhill <0xeffeff@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] net: vrf: correct FRA_L3MDEV encode type
Date: Wed, 1 Nov 2017 13:30:58 -0600 [thread overview]
Message-ID: <4720426f-065f-bd61-2dad-55ddb6fe18ee@gmail.com> (raw)
In-Reply-To: <20171101145809.2362-1-0xeffeff@gmail.com>
On 11/1/17 8:58 AM, Jeff Barnhill wrote:
> FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On
> big endian architecture, this results in the l3mdev entry not being
> added to the FIB rules.
>
> Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create")
> Signed-off-by: Jeff Barnhill <0xeffeff@gmail.com>
> ---
> drivers/net/vrf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c
> index 9b243e6f3008..7dc3bcac3506 100644
> --- a/drivers/net/vrf.c
> +++ b/drivers/net/vrf.c
> @@ -1165,7 +1165,7 @@ static int vrf_fib_rule(const struct net_device *dev, __u8 family, bool add_it)
> frh->family = family;
> frh->action = FR_ACT_TO_TBL;
>
> - if (nla_put_u32(skb, FRA_L3MDEV, 1))
> + if (nla_put_u8(skb, FRA_L3MDEV, 1))
> goto nla_put_failure;
>
> if (nla_put_u32(skb, FRA_PRIORITY, FIB_RULE_PREF))
>
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2017-11-01 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 14:58 [PATCH] net: vrf: correct FRA_L3MDEV encode type Jeff Barnhill
2017-11-01 19:30 ` David Ahern [this message]
2017-11-02 7:22 ` David Miller
2017-11-02 19:18 ` David Ahern
-- strict thread matches above, loose matches on Subject: below --
2017-11-01 1:24 Jeff Barnhill
2017-11-01 2:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4720426f-065f-bd61-2dad-55ddb6fe18ee@gmail.com \
--to=dsahern@gmail.com \
--cc=0xeffeff@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).