From: Rick Jones <rick.jones2@hp.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH] dev_change_name: ignore changes to same name
Date: Fri, 26 Oct 2007 10:51:13 -0700 [thread overview]
Message-ID: <47222911.7040106@hp.com> (raw)
In-Reply-To: <20071026.035352.114927735.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Wed, 24 Oct 2007 06:44:45 -0700
>
>
>>Prevent error/backtrace from dev_rename() when changing
>>name of network device to the same name. This is a common
>>situation with udev and other scripts that bind addr to device.
>>
>>Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
>
> Fair enough, applied.
Very timely! I'd just built/booted a 2.6.24-rc1 kernel yesterday and it spent
quite a long time with stack traces (I have 16 interfaces on the system and a
9600 baud console...I can only imagine what it would have been like on a big
system...). With the patch applied to that tree, it is now down to only three
or so stack traces related to renames that were not there on 2.6.23.mumble. Not
sure if that warrants an acked-by but feel free if it makes sense. (I'm still
really fuzzy on those, even after reading SubmittingPatches)
rick jones
prev parent reply other threads:[~2007-10-26 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 13:44 [PATCH] dev_change_name: ignore changes to same name Stephen Hemminger
2007-10-26 10:53 ` David Miller
2007-10-26 17:51 ` Rick Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47222911.7040106@hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).