From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: netdev@vger.kernel.org, Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH 1] net: fix and typo's
Date: Fri, 26 Oct 2007 13:06:13 -0700 [thread overview]
Message-ID: <472248B5.1020704@intel.com> (raw)
In-Reply-To: <4722460E.4010201@tiscali.nl>
Roel Kluin wrote:
> Kok, Auke wrote:
>
>> Ack this e1000e change here!
>
>> (PS since there was only 1 netdriver patch here and the rest is wireless, I would
>> have suggested splitting this patch up in two and sending them to the wireless
>> maintainer and netdevice maintainer separately. But I'm sure this will get picked
>> up anyway.)
>
> Ok, I've split the patch and sent the rest to wireless. Here's this single fix again
> you acked.
OK, bedankt Roel!
I'll forward this to Jeff for merging.
Cheers,
Auke
> --
> Fix priority mistakes similar to '!x & y'
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c
> index cf70522..14141a5 100644
> --- a/drivers/net/e1000e/82571.c
> +++ b/drivers/net/e1000e/82571.c
> @@ -283,7 +283,7 @@ static s32 e1000_get_invariants_82571(struct e1000_adapter *adapter)
> adapter->flags &= ~FLAG_HAS_WOL;
> /* quad ports only support WoL on port A */
> if (adapter->flags & FLAG_IS_QUAD_PORT &&
> - (!adapter->flags & FLAG_IS_QUAD_PORT_A))
> + (!(adapter->flags & FLAG_IS_QUAD_PORT_A)))
> adapter->flags &= ~FLAG_HAS_WOL;
> break;
>
next prev parent reply other threads:[~2007-10-26 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 17:07 [PATCH 1] net: fix and typo's Roel Kluin
2007-10-26 17:51 ` Kok, Auke
2007-10-26 19:54 ` Roel Kluin
2007-10-26 20:06 ` Kok, Auke [this message]
2007-10-26 18:25 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472248B5.1020704@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=12o3l@tiscali.nl \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).