From: Rick Jones <rick.jones2@hp.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Adrian Bunk <bunk@kernel.org>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] always export sysctl_{r,w}mem_max
Date: Fri, 26 Oct 2007 16:31:47 -0700 [thread overview]
Message-ID: <472278E3.4000909@hp.com> (raw)
In-Reply-To: <m1zly5wjie.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman wrote:
> Adrian Bunk <bunk@kernel.org> writes:
>
>
>>This patch fixes the following build error with CONFIG_SYSCTL=n:
>>
>><-- snip -->
>>
>>...
>>ERROR: "sysctl_rmem_max" [fs/dlm/dlm.ko] undefined!
>>ERROR: "sysctl_wmem_max" [drivers/net/rrunner.ko] undefined!
>>ERROR: "sysctl_rmem_max" [drivers/net/rrunner.ko] undefined!
>>make[2]: *** [__modpost] Error 1
>
>
> I was going to ask if allowing drivers to increase rmem_max
> is something that we want to do. Apparently the road runner
> driver has been doing this since the 2.6.12-rc1 when the
> git repository starts so this probably isn't a latent bug.
Although it does rather sound like a driver writer yanking the rope from the
hand's of the sysadmin and hanging him with it rather than letting the sysadmin
do it himself. I've seen other drivers' README's suggesting larger mem's but
not their sources doing it.
rick jones
next prev parent reply other threads:[~2007-10-26 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 23:08 [2.6 patch] always export sysctl_{r,w}mem_max Adrian Bunk
2007-10-26 23:20 ` Eric W. Biederman
2007-10-26 23:31 ` Rick Jones [this message]
2007-10-26 23:39 ` David Miller
2007-10-26 23:46 ` Rick Jones
2007-10-26 23:52 ` David Miller
2007-10-27 0:04 ` Eric W. Biederman
2007-11-07 7:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472278E3.4000909@hp.com \
--to=rick.jones2@hp.com \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).