From: Jeff Garzik <jeff@garzik.org>
To: Sivakumar Subramani <Sivakumar.Subramani@neterion.com>
Cc: netdev@vger.kernel.org, support@neterion.com
Subject: Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails
Date: Mon, 29 Oct 2007 05:55:44 -0400 [thread overview]
Message-ID: <4725AE20.7000400@garzik.org> (raw)
In-Reply-To: <Pine.GSO.4.10.10710280403250.29009-100000@guinness>
Sivakumar Subramani wrote:
> - Fixed memory leak by freeing MSI-X local entry memories when vector allocation
> fails in s2io_add_isr.
> - Added two utility functions do_rem_msix_isr and do_rem_inta_isr to eliminate
> code duplication.
>
> Signed-off-by: Veena Parat <veena.parat@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
> Signed-off-by: Santosh Rastapur <santosh.rastapur@neterion.com>
Comments:
1) stats->mem_freed is redundant to general kernel debugging facilities
2) synchronize_irq() is redundant, free_irq() does same
3) "rem" isn't very clear. few if any other kernel drivers use this to
indicate "remove"
4) "do_" prefix is redundant
5) scripts/checkpatch.pl fails on this patch. please clean up problems.
The main issue for this patch is #2, though presumably the other stuff
can be cleaned on the next resubmit
next prev parent reply other threads:[~2007-10-29 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 8:05 [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails Sivakumar Subramani
2007-10-29 9:55 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-31 8:10 Sreenivasa Honnur
2007-11-06 17:46 ` Jeff Garzik
2007-11-14 9:29 Sreenivasa Honnur
2007-11-14 9:41 ` David Miller
2007-11-24 3:03 ` Jeff Garzik
2007-11-24 5:48 ` Ramkrishna Vepa
2007-11-24 6:56 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4725AE20.7000400@garzik.org \
--to=jeff@garzik.org \
--cc=Sivakumar.Subramani@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=support@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).