* [PATCH] Fix ethernet multicast for ucc_geth.
@ 2007-10-17 9:05 Joakim Tjernlund
2007-10-18 14:24 ` Li Yang-r58472
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Joakim Tjernlund @ 2007-10-17 9:05 UTC (permalink / raw)
To: Netdev, Li Yang-r58472
>From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Date: Wed, 17 Oct 2007 11:01:44 +0200
Subject: [PATCH] Fix ethernet multicast for ucc_geth.
hw_add_addr_in_hash() already swaps byte
order, don't do it in ucc_geth_set_multi() too.
Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
drivers/net/ucc_geth.c | 15 ++-------------
1 files changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
index 61f5cce..f649b1e 100644
--- a/drivers/net/ucc_geth.c
+++ b/drivers/net/ucc_geth.c
@@ -2214,9 +2214,7 @@ static void ucc_geth_set_multi(struct net_device *dev)
struct dev_mc_list *dmi;
struct ucc_fast *uf_regs;
struct ucc_geth_82xx_address_filtering_pram *p_82xx_addr_filt;
- u8 tempaddr[6];
- u8 *mcptr, *tdptr;
- int i, j;
+ int i;
ugeth = netdev_priv(dev);
@@ -2255,19 +2253,10 @@ static void ucc_geth_set_multi(struct net_device *dev)
if (!(dmi->dmi_addr[0] & 1))
continue;
- /* The address in dmi_addr is LSB first,
- * and taddr is MSB first. We have to
- * copy bytes MSB first from dmi_addr.
- */
- mcptr = (u8 *) dmi->dmi_addr + 5;
- tdptr = (u8 *) tempaddr;
- for (j = 0; j < 6; j++)
- *tdptr++ = *mcptr--;
-
/* Ask CPM to run CRC and set bit in
* filter mask.
*/
- hw_add_addr_in_hash(ugeth, tempaddr);
+ hw_add_addr_in_hash(ugeth, dmi->dmi_addr);
}
}
}
--
1.5.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] Fix ethernet multicast for ucc_geth.
2007-10-17 9:05 [PATCH] Fix ethernet multicast for ucc_geth Joakim Tjernlund
@ 2007-10-18 14:24 ` Li Yang-r58472
2007-10-21 9:45 ` Joakim Tjernlund
2007-10-29 10:05 ` Jeff Garzik
2007-10-29 10:11 ` Jeff Garzik
2 siblings, 1 reply; 6+ messages in thread
From: Li Yang-r58472 @ 2007-10-18 14:24 UTC (permalink / raw)
To: joakim.tjernlund, Netdev, linuxppc-dev
> -----Original Message-----
> From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> Sent: Wednesday, October 17, 2007 5:06 PM
> To: Netdev; Li Yang-r58472
> Subject: [PATCH] Fix ethernet multicast for ucc_geth.
>
> >From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17
> 00:00:00 2001
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Wed, 17 Oct 2007 11:01:44 +0200
> Subject: [PATCH] Fix ethernet multicast for ucc_geth.
> hw_add_addr_in_hash() already swaps byte order, don't do it
> in ucc_geth_set_multi() too.
>
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Acked-by: Li Yang <leoli@freescale.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Fix ethernet multicast for ucc_geth.
2007-10-18 14:24 ` Li Yang-r58472
@ 2007-10-21 9:45 ` Joakim Tjernlund
0 siblings, 0 replies; 6+ messages in thread
From: Joakim Tjernlund @ 2007-10-21 9:45 UTC (permalink / raw)
To: 'Li Yang-r58472', 'Netdev', linuxppc-dev
> -----Original Message-----
> From: Li Yang-r58472 [mailto:LeoLi@freescale.com]
> Sent: den 18 oktober 2007 16:24
> To: joakim.tjernlund@transmode.se; Netdev; linuxppc-dev@ozlabs.org
> Subject: RE: [PATCH] Fix ethernet multicast for ucc_geth.
>
> > -----Original Message-----
> > From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> > Sent: Wednesday, October 17, 2007 5:06 PM
> > To: Netdev; Li Yang-r58472
> > Subject: [PATCH] Fix ethernet multicast for ucc_geth.
> >
> > >From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17
> > 00:00:00 2001
> > From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > Date: Wed, 17 Oct 2007 11:01:44 +0200
> > Subject: [PATCH] Fix ethernet multicast for ucc_geth.
> > hw_add_addr_in_hash() already swaps byte order, don't do it
> > in ucc_geth_set_multi() too.
> >
> >
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
>
> Acked-by: Li Yang <leoli@freescale.com>
>
Ping? Did this make into a someones tree?
Jocke
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ethernet multicast for ucc_geth.
2007-10-17 9:05 [PATCH] Fix ethernet multicast for ucc_geth Joakim Tjernlund
2007-10-18 14:24 ` Li Yang-r58472
@ 2007-10-29 10:05 ` Jeff Garzik
2007-10-29 10:07 ` Li Yang-r58472
2007-10-29 10:11 ` Jeff Garzik
2 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-10-29 10:05 UTC (permalink / raw)
To: joakim.tjernlund, Li Yang-r58472; +Cc: Netdev
Joakim Tjernlund wrote:
>>From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Wed, 17 Oct 2007 11:01:44 +0200
> Subject: [PATCH] Fix ethernet multicast for ucc_geth.
> hw_add_addr_in_hash() already swaps byte
> order, don't do it in ucc_geth_set_multi() too.
>
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> drivers/net/ucc_geth.c | 15 ++-------------
> 1 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c
> index 61f5cce..f649b1e 100644
> --- a/drivers/net/ucc_geth.c
> +++ b/drivers/net/ucc_geth.c
> @@ -2214,9 +2214,7 @@ static void ucc_geth_set_multi(struct net_device *dev)
> struct dev_mc_list *dmi;
> struct ucc_fast *uf_regs;
> struct ucc_geth_82xx_address_filtering_pram *p_82xx_addr_filt;
> - u8 tempaddr[6];
> - u8 *mcptr, *tdptr;
> - int i, j;
> + int i;
>
> ugeth = netdev_priv(dev);
>
> @@ -2255,19 +2253,10 @@ static void ucc_geth_set_multi(struct net_device *dev)
> if (!(dmi->dmi_addr[0] & 1))
> continue;
>
> - /* The address in dmi_addr is LSB first,
> - * and taddr is MSB first. We have to
> - * copy bytes MSB first from dmi_addr.
> - */
> - mcptr = (u8 *) dmi->dmi_addr + 5;
> - tdptr = (u8 *) tempaddr;
> - for (j = 0; j < 6; j++)
> - *tdptr++ = *mcptr--;
> -
> /* Ask CPM to run CRC and set bit in
> * filter mask.
> */
> - hw_add_addr_in_hash(ugeth, tempaddr);
> + hw_add_addr_in_hash(ugeth, dmi->dmi_addr);
did the maintainer ever ACK this?
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] Fix ethernet multicast for ucc_geth.
2007-10-29 10:05 ` Jeff Garzik
@ 2007-10-29 10:07 ` Li Yang-r58472
0 siblings, 0 replies; 6+ messages in thread
From: Li Yang-r58472 @ 2007-10-29 10:07 UTC (permalink / raw)
To: Jeff Garzik, joakim.tjernlund; +Cc: Netdev
> > @@ -2255,19 +2253,10 @@ static void
> ucc_geth_set_multi(struct net_device *dev)
> > if (!(dmi->dmi_addr[0] & 1))
> > continue;
> >
> > - /* The address in dmi_addr is LSB first,
> > - * and taddr is MSB first. We have to
> > - * copy bytes MSB first from dmi_addr.
> > - */
> > - mcptr = (u8 *) dmi->dmi_addr + 5;
> > - tdptr = (u8 *) tempaddr;
> > - for (j = 0; j < 6; j++)
> > - *tdptr++ = *mcptr--;
> > -
> > /* Ask CPM to run CRC and set bit in
> > * filter mask.
> > */
> > - hw_add_addr_in_hash(ugeth, tempaddr);
> > + hw_add_addr_in_hash(ugeth,
> dmi->dmi_addr);
>
> did the maintainer ever ACK this?
Yes, I did. :)
- Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix ethernet multicast for ucc_geth.
2007-10-17 9:05 [PATCH] Fix ethernet multicast for ucc_geth Joakim Tjernlund
2007-10-18 14:24 ` Li Yang-r58472
2007-10-29 10:05 ` Jeff Garzik
@ 2007-10-29 10:11 ` Jeff Garzik
2 siblings, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2007-10-29 10:11 UTC (permalink / raw)
To: joakim.tjernlund; +Cc: Netdev, Li Yang-r58472
Joakim Tjernlund wrote:
>>From 5761a9e5924b34615c748fba2dcb977ed04c1243 Mon Sep 17 00:00:00 2001
> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> Date: Wed, 17 Oct 2007 11:01:44 +0200
> Subject: [PATCH] Fix ethernet multicast for ucc_geth.
> hw_add_addr_in_hash() already swaps byte
> order, don't do it in ucc_geth_set_multi() too.
>
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> drivers/net/ucc_geth.c | 15 ++-------------
> 1 files changed, 2 insertions(+), 13 deletions(-)
applied
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-10-29 10:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-17 9:05 [PATCH] Fix ethernet multicast for ucc_geth Joakim Tjernlund
2007-10-18 14:24 ` Li Yang-r58472
2007-10-21 9:45 ` Joakim Tjernlund
2007-10-29 10:05 ` Jeff Garzik
2007-10-29 10:07 ` Li Yang-r58472
2007-10-29 10:11 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).