From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: pcnet32@verizon.net, netdev@vger.kernel.org
Subject: Re: [PATCH] pcnet: fix sparse triviality
Date: Mon, 29 Oct 2007 10:54:25 -0700 [thread overview]
Message-ID: <47261E51.2000301@intel.com> (raw)
In-Reply-To: <4725B045.80705@garzik.org>
Jeff Garzik wrote:
> Auke Kok wrote:
>> Since data can never exceed u32, it can't even be larger than
>> LONG_MAX/HZ.
>>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
>> Cc: pcnet32@verizon.net
>> ---
>>
> Two comments:
>
> 1) I would prefer to pick a sane limit, like "1 day". The unit of
> 'data' is seconds, so IMO we should not allow stupid timeouts, much less
> INT_MAX ones :) But hey, then again, maybe we should permit root to
> hang themselves with own rope...
well, in this case it's only used for the blink interval for the LED on the back
of the adapter. This is completely interruptable by the user with ^C when running
ethtool, so it's not going to hang anything (traffic should continue nicely).
yes INT_MAX is insanely long. moving all of this checking to the ethtool generic
code makes much more sense indeed.
> 2) [tangent] someone really should add the obvious ssleep_interruptible()
*pass* :)
Auke
prev parent reply other threads:[~2007-10-29 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 22:11 [PATCH] pcnet: fix sparse triviality Auke Kok
2007-10-29 10:04 ` Jeff Garzik
2007-10-29 17:54 ` Kok, Auke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47261E51.2000301@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).