netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: zenyowu@tw.ibm.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.24] ixgb: TX hangs under heavy load
Date: Tue, 30 Oct 2007 09:12:11 -0700	[thread overview]
Message-ID: <472757DB.1060308@intel.com> (raw)
In-Reply-To: <20071030125055.GA7195@gospo.rdu.redhat.com>

Andy Gospodarek wrote:
> Auke,
> 
> It has become clear that this patch resolves some tx-lockups on the ixgb
> driver.  IBM did some checking and realized this hunk is in your
> sourceforge driver, but not anywhere else.  Mind if we add it?


I'll quickly double check where this came from in the first place and will post
this to Jeff

Thanks!

Auke


> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
> 
> ---
> 
>  ixgb_main.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> index d444de5..3ec7a41 100644
> --- a/drivers/net/ixgb/ixgb_main.c
> +++ b/drivers/net/ixgb/ixgb_main.c
> @@ -1324,7 +1324,7 @@ ixgb_tx_map(struct ixgb_adapter *adapter, struct sk_buff *skb,
>  
>  			/* Workaround for premature desc write-backs
>  			 * in TSO mode.  Append 4-byte sentinel desc */
> -			if (unlikely(mss && !nr_frags && size == len
> +			if (unlikely(mss && (f == (nr_frags-1)) && size == len
>  			             && size > 8))
>  				size -= 4;
>  

      reply	other threads:[~2007-10-30 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 12:50 [PATCH 2.6.24] ixgb: TX hangs under heavy load Andy Gospodarek
2007-10-30 16:12 ` Kok, Auke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472757DB.1060308@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=andy@greyhouse.net \
    --cc=netdev@vger.kernel.org \
    --cc=zenyowu@tw.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).