* [PATCH 2.6.24] ixgb: TX hangs under heavy load
@ 2007-10-30 12:50 Andy Gospodarek
2007-10-30 16:12 ` Kok, Auke
0 siblings, 1 reply; 2+ messages in thread
From: Andy Gospodarek @ 2007-10-30 12:50 UTC (permalink / raw)
To: auke-jan.h.kok; +Cc: zenyowu, netdev
Auke,
It has become clear that this patch resolves some tx-lockups on the ixgb
driver. IBM did some checking and realized this hunk is in your
sourceforge driver, but not anywhere else. Mind if we add it?
Thanks,
-andy
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
---
ixgb_main.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
index d444de5..3ec7a41 100644
--- a/drivers/net/ixgb/ixgb_main.c
+++ b/drivers/net/ixgb/ixgb_main.c
@@ -1324,7 +1324,7 @@ ixgb_tx_map(struct ixgb_adapter *adapter, struct sk_buff *skb,
/* Workaround for premature desc write-backs
* in TSO mode. Append 4-byte sentinel desc */
- if (unlikely(mss && !nr_frags && size == len
+ if (unlikely(mss && (f == (nr_frags-1)) && size == len
&& size > 8))
size -= 4;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.24] ixgb: TX hangs under heavy load
2007-10-30 12:50 [PATCH 2.6.24] ixgb: TX hangs under heavy load Andy Gospodarek
@ 2007-10-30 16:12 ` Kok, Auke
0 siblings, 0 replies; 2+ messages in thread
From: Kok, Auke @ 2007-10-30 16:12 UTC (permalink / raw)
To: Andy Gospodarek; +Cc: zenyowu, netdev
Andy Gospodarek wrote:
> Auke,
>
> It has become clear that this patch resolves some tx-lockups on the ixgb
> driver. IBM did some checking and realized this hunk is in your
> sourceforge driver, but not anywhere else. Mind if we add it?
I'll quickly double check where this came from in the first place and will post
this to Jeff
Thanks!
Auke
> Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
>
> ---
>
> ixgb_main.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
> index d444de5..3ec7a41 100644
> --- a/drivers/net/ixgb/ixgb_main.c
> +++ b/drivers/net/ixgb/ixgb_main.c
> @@ -1324,7 +1324,7 @@ ixgb_tx_map(struct ixgb_adapter *adapter, struct sk_buff *skb,
>
> /* Workaround for premature desc write-backs
> * in TSO mode. Append 4-byte sentinel desc */
> - if (unlikely(mss && !nr_frags && size == len
> + if (unlikely(mss && (f == (nr_frags-1)) && size == len
> && size > 8))
> size -= 4;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-30 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 12:50 [PATCH 2.6.24] ixgb: TX hangs under heavy load Andy Gospodarek
2007-10-30 16:12 ` Kok, Auke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).