Netdev List
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, opendmb@gmail.com, nb@tipi-net.de,
	bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
	hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
	linux-kernel@vger.kernel.org, kudzo51@gmail.com
Subject: Re: [PATCH net-next v4 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan
Date: Fri, 20 Nov 2026 11:04:43 -0800	[thread overview]
Message-ID: <47288660-1e56-455f-9686-ee58146bb865@broadcom.com> (raw)
In-Reply-To: <179515311013.3136.13885466048757926038@kernel.org>

On 11/19/26 21:38, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
> 
> Low priority / nit picks for your consideration:
> 
> - [Low] The -EIO/-ENODEV -> -ENODEV mapping in get_phy_c45_ids()
>    (drivers/net/phy/phy_device.c) applies to every caller, not only…

Agreed. The commit message now says that get_phy_c45_ids() is reached 
through get_phy_device(bus, addr, true) and phy_get_c45_ids(). It lists 
the effect on the other callers: of_mdio logs the missing device and 
registers the bus without it, sfp ends up with "no PHY detected" after 
the usual retries, and gpy_probe() now gets -ENODEV, which the driver 
core treats as a silent match rejection. This matches what C22 callers 
already get from get_phy_c22_id().

> - [Low] The commit message gives the UniMAC MDIO block (MDIO_READ_FAIL)
>    as its example of a controller whose read_c45() reports an empty…

The commit message now says that mdio-bcm-unimac does not provide 
read_c45() yet and that it is enabled by "net: mdio: mdio-bcm-unimac: 
Add Clause 45 support" later in the series.

> - [Low] The patch rewrites the kernel-doc of get_phy_c45_ids() (lines
>    826-828) and of the exported phy_get_c45_ids() (lines 1107-1109).

That call is intentionally left unmapped. It only runs once a device has
  answered, and mapping a bus error there to -ENODEV would make a PHY 
that fails midway disappear silently instead of failing the probe. I 
chose the second option you suggested and reworded the kernel-doc of 
both get_phy_c45_ids() and phy_get_c45_ids() to say "or a negative error 
code from a failed bus access otherwise (usually -EIO)". The commit 
message also states that the vendor MMD presence check and the 
identifier reads are not mapped.

pw-bot: cr
-- 
Florian

  reply	other threads:[~2026-11-20 19:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  0:59 [PATCH net-next v4 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Florian Fainelli
2026-11-19  0:59 ` [PATCH net-next v4 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan Florian Fainelli
2026-11-20  5:38   ` netdev-bot+sashiko
2026-11-20 19:04     ` Florian Fainelli [this message]
2026-11-19  0:59 ` [PATCH net-next v4 2/4] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT Florian Fainelli
2026-11-19  0:59 ` [PATCH net-next v4 3/4] net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity Florian Fainelli
2026-11-19  0:59 ` [PATCH net-next v4 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
2026-11-20  5:38   ` netdev-bot+sashiko
2026-11-20 19:10     ` Florian Fainelli
  -- strict thread matches above, loose matches on Subject: below --
2026-11-20  5:16 [PATCH net-next v4 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Florian Fainelli
2026-11-20  5:16 ` [PATCH net-next v4 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47288660-1e56-455f-9686-ee58146bb865@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kudzo51@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nb@tipi-net.de \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox