From: Pavel Emelyanov <xemul@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>, devel@openvz.org
Subject: [PATCH 7/8] Remove bogus zero_it argument from sk_alloc
Date: Wed, 31 Oct 2007 16:56:10 +0300 [thread overview]
Message-ID: <4728897A.50607@openvz.org> (raw)
In-Reply-To: <472885B1.7090103@openvz.org>
At this point nobody calls the sk_alloc(() with zero_it == 0,
so remove unneeded checks from it.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/core/sock.c b/net/core/sock.c
index c032f48..77575c3 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -931,21 +931,16 @@ struct sock *sk_alloc(struct net *net, int family, gfp_t priority,
{
struct sock *sk;
- if (zero_it)
- priority |= __GFP_ZERO;
-
- sk = sk_prot_alloc(prot, priority, family);
+ sk = sk_prot_alloc(prot, priority | __GFP_ZERO, family);
if (sk) {
- if (zero_it) {
- sk->sk_family = family;
- /*
- * See comment in struct sock definition to understand
- * why we need sk_prot_creator -acme
- */
- sk->sk_prot = sk->sk_prot_creator = prot;
- sock_lock_init(sk);
- sk->sk_net = get_net(net);
- }
+ sk->sk_family = family;
+ /*
+ * See comment in struct sock definition to understand
+ * why we need sk_prot_creator -acme
+ */
+ sk->sk_prot = sk->sk_prot_creator = prot;
+ sock_lock_init(sk);
+ sk->sk_net = get_net(net);
}
return sk;
--
1.5.3.4
next prev parent reply other threads:[~2007-10-31 12:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 13:40 [PATCH 0/8] Cleanup/fix the sk_alloc() call Pavel Emelyanov
2007-10-31 13:15 ` Arnaldo Carvalho de Melo
2007-10-31 14:32 ` Pavel Emelyanov
2007-10-31 14:14 ` Arnaldo Carvalho de Melo
2007-10-31 13:42 ` [PATCH 1/8] Move the sock_copy() from the header Pavel Emelyanov
2007-11-01 7:30 ` David Miller
2007-10-31 13:44 ` [PATCH 2/8] Move the get_net() from sock_copy() Pavel Emelyanov
2007-11-01 7:32 ` David Miller
2007-10-31 13:47 ` [PATCH 3/8] Cleanup the allocation/freeing of the sock object Pavel Emelyanov
2007-11-01 7:34 ` David Miller
2007-10-31 13:48 ` [PATCH 4/8] Auto-zero the allocated " Pavel Emelyanov
2007-11-01 7:35 ` David Miller
2007-10-31 13:51 ` [PATCH 5/8] Move some core sock setup into sk_prot_alloc Pavel Emelyanov
2007-11-01 7:36 ` David Miller
2007-10-31 13:54 ` [PATCH 6/8] Make the sk_clone() lighter Pavel Emelyanov
2007-11-01 7:26 ` David Miller
2007-11-01 8:46 ` Pavel Emelyanov
2007-11-01 7:38 ` David Miller
2007-10-31 13:56 ` Pavel Emelyanov [this message]
2007-11-01 7:38 ` [PATCH 7/8] Remove bogus zero_it argument from sk_alloc David Miller
2007-10-31 13:59 ` [PATCH 8/8] Forget the zero_it argument of sk_alloc() Pavel Emelyanov
2007-11-01 7:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4728897A.50607@openvz.org \
--to=xemul@openvz.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).