* drivers/net/tlan question
@ 2007-10-31 17:59 Gabriel C
2007-10-31 18:08 ` [PATCH] tlan list is subscribers-only Gabriel C
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel C @ 2007-10-31 17:59 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: netdev, tlan-devel, chessman
Hi,
I noticed on current git the following warning with !CONFIG_PCI :
...
drivers/net/tlan.c: In function 'TLan_probe1':
drivers/net/tlan.c:682: warning: label 'err_out' defined but not used
...
I thought a simply #ifdef is missing but looking at TLan_probe1() I got confused about err_out_regions
...
#ifdef CONFIG_PCI
if (pdev) {
rc = pci_enable_device(pdev);
if (rc)
return rc;
rc = pci_request_regions(pdev, TLanSignature);
if (rc) {
printk(KERN_ERR "TLAN: Could not reserve IO regions\n");
goto err_out;
}
}
#endif /* CONFIG_PCI */
dev = alloc_etherdev(sizeof(TLanPrivateInfo));
if (dev == NULL) {
printk(KERN_ERR "TLAN: Could not allocate memory for device.\n");
rc = -ENOMEM;
goto err_out_regions;
}
...
...
err_out_regions:
#ifdef CONFIG_PCI
if (pdev)
pci_release_regions(pdev);
#endif
err_out:
if (pdev)
pci_disable_device(pdev);
return rc;
...
It is possible 'dev' to be NULL with !CONFIG_PCI ? If is true then err_out_regions: does nothing ?
Does this look right ?
Regards,
Gabriel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] tlan list is subscribers-only
2007-10-31 17:59 drivers/net/tlan question Gabriel C
@ 2007-10-31 18:08 ` Gabriel C
0 siblings, 0 replies; 2+ messages in thread
From: Gabriel C @ 2007-10-31 18:08 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: netdev, chessman
...
Your mail to 'Tlan-devel' with the subject
drivers/net/tlan question
Is being held until the list moderator can review it for approval.
The reason it is being held:
Post by non-member to a members-only list
...
Signed-off-by: Gabriel Craciunescu <nix.or.die@googlemail.com>
---
MAINTAINERS | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4a26f83..6a116f3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3729,7 +3729,7 @@ S: Maintained
TLAN NETWORK DRIVER
P: Samuel Chessman
M: chessman@tux.org
-L: tlan-devel@lists.sourceforge.net
+L: tlan-devel@lists.sourceforge.net (subscribers-only)
W: http://sourceforge.net/projects/tlan/
S: Maintained
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-31 18:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-31 17:59 drivers/net/tlan question Gabriel C
2007-10-31 18:08 ` [PATCH] tlan list is subscribers-only Gabriel C
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).