From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kok, Auke" Subject: Re: [PATCH] e1000, e1000e valid-addr fixes Date: Thu, 01 Nov 2007 11:04:22 -0700 Message-ID: <472A1526.8070208@intel.com> References: <471E99E8.6030404@garzik.org> <20071023.180744.115914004.davem@davemloft.net> <471EABEE.8030900@garzik.org> <20071023.192313.115635750.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: jeff@garzik.org, netdev@vger.kernel.org, davej@redhat.com, ajax@redhat.com, linux-kernel@vger.kernel.org To: David Miller Return-path: Received: from mga11.intel.com ([192.55.52.93]:20510 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbXKASGt (ORCPT ); Thu, 1 Nov 2007 14:06:49 -0400 In-Reply-To: <20071023.192313.115635750.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org David Miller wrote: > From: Jeff Garzik > Date: Tue, 23 Oct 2007 22:20:30 -0400 > >> David Miller wrote: >>> From: Jeff Garzik >>> Date: Tue, 23 Oct 2007 21:03:36 -0400 >>> >>>> I'm wondering if there is a way to avoid adding >>>> >>>> if (!is_valid_ether_addr(dev->dev_addr)) >>>> return -EINVAL; >>>> >>>> to every ethernet driver's ->open() hook. >>> The first idea I get is: >>> >>> 1) Create netdev->validate_dev_addr(). >>> >>> 2) If it exists, invoke it before ->open(), abort >>> and return if any errors signaled. >>> >>> etherdev init hooks up a function that does the above >>> check, which allows us to avoid editing every ethernet >>> driver >>> >>> What do you think? >> Seems sane to me. Something like this (attached)? > > Looks great: > > Acked-by: David S. Miller I like it. Should I start sending patches to remove the checks from e1000/e1000e/ixgb/ixgbe already (to David, I assume?)? Auke