From: <samuel@sortiz.org>
To: Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch, v2.6.26-rc5] net/irda build fix: mcs7780
Date: Mon, 09 Jun 2008 11:26:37 +0200 [thread overview]
Message-ID: <47304c8330b37ab2677d72f8c8adbe12@localhost> (raw)
In-Reply-To: <20080609082257.GA15282@elte.hu>
On Mon, 9 Jun 2008 10:22:57 +0200, Ingo Molnar <mingo@elte.hu> wrote:
>
> -tip testing found the following build error:
>
> drivers/built-in.o: In function `mcs_receive_irq':
> mcs7780.c:(.text+0x4e429): undefined reference to `crc32_le'
> drivers/built-in.o: In function `mcs_hard_xmit':
> mcs7780.c:(.text+0x4e9af): undefined reference to `crc32_le'
>
> with:
>
> http://redhat.com/~mingo/misc/config-Sun_Jun__8_22_56_14_CEST_2008.bad
>
> the reason is a missing enablement of the CRC32 library in the Kconfig.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Many thanks Ingo.
Dave, I can take it with my next IrDA patch set. But since it's a build
failure, you may want to take it immediatly, it's up to you.
In the latter case:
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
> ---
> drivers/net/irda/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux/drivers/net/irda/Kconfig
> ===================================================================
> --- linux.orig/drivers/net/irda/Kconfig
> +++ linux/drivers/net/irda/Kconfig
> @@ -329,6 +329,7 @@ config PXA_FICP
> config MCS_FIR
> tristate "MosChip MCS7780 IrDA-USB dongle"
> depends on IRDA && USB && EXPERIMENTAL
> + select CRC32
> help
> Say Y or M here if you want to build support for the MosChip
> MCS7780 IrDA-USB bridge device driver.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-09 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 0:01 [GIT]: Networking David Miller
2008-06-09 8:22 ` [patch, v2.6.26-rc5] net/irda build fix: mcs7780 Ingo Molnar
2008-06-09 9:26 ` samuel [this message]
2008-06-09 22:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47304c8330b37ab2677d72f8c8adbe12@localhost \
--to=samuel@sortiz.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).