From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Arlott Subject: Re: [PATCH 02/05] ipv6: RFC4214 Support Date: Wed, 07 Nov 2007 19:01:47 +0000 Message-ID: <47320B9B.6050301@simon.arlott.org.uk> References: <200711071658.59478.netdev@axxeo.de><20071108.031214.124029872.yoshfuji@linux-ipv6.org><39C363776A4E8C4A94691D2BD9D1C9A1029EDBF2@XCH-NW-7V2.nw.nos.boeing.com> <20071108.034840.124896893.yoshfuji@linux-ipv6.org> <39C363776A4E8C4A94691D2BD9D1C9A1029EDBF4@XCH-NW-7V2.nw.nos.boeing.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: =?UTF-8?B?WU9TSElGVUpJIEhpZGVha2kgLyDlkInol6Toi7HmmI4=?= , netdev@axxeo.de, netdev@vger.kernel.org To: "Templin, Fred L" Return-path: Received: from proxima.lp0.eu ([85.158.45.36]:50076 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbXKGTB5 (ORCPT ); Wed, 7 Nov 2007 14:01:57 -0500 In-Reply-To: <39C363776A4E8C4A94691D2BD9D1C9A1029EDBF4@XCH-NW-7V2.nw.nos.boeing.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/11/07 18:52, Templin, Fred L wrote: >> > > > > + eui[0] = 0; >> > > > > + >> > > > > + /* Check for RFC3330 global address ranges */ >> > > > > + if (((ipv4 >= 0x01000000) && (ipv4 < 0x0a000000)) || >> > > > > + ((ipv4 >= 0x0b000000) && (ipv4 < 0x7f000000)) || >> > > > > + ((ipv4 >= 0x80000000) && (ipv4 < 0xa9fe0000)) || >> > > > > + ((ipv4 >= 0xa9ff0000) && (ipv4 < 0xac100000)) || >> > > > > + ((ipv4 >= 0xac200000) && (ipv4 < 0xc0a80000)) || >> > > > > + ((ipv4 >= 0xc0a90000) && (ipv4 < 0xc6120000)) || >> > > > > + ((ipv4 >= 0xc6140000) && (ipv4 < >> 0xe0000000))) eui[0] |= >> > > > > 0x2; >> I don't understand. >> >> For example, 1.0.0.11 is valid IPv4 global address. >> In little-endian, this is not in the range of >> 0x00000001 <= addr <= 0x0000000a (addr is 0x0b000001). > > Maybe it is I who did not understand. Can you suggest a clean solution? ((ipv4 & htonl(0xFF000000)) == htonl(0x0A000000)) etc.? -- Simon Arlott