* Re: Fwd: Re: [PATCH] iSCSI fix endieness of digest to be network byte order
[not found] ` <20071108170409B.fujita.tomonori@lab.ntt.co.jp>
@ 2007-11-08 10:40 ` Herbert Xu
2007-11-08 15:47 ` Vlad Yasevich
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2007-11-08 10:40 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: bhalevy, linux-crypto, michaelc, netdev
On Thu, Nov 08, 2007 at 05:04:09PM +0900, FUJITA Tomonori wrote:
>
> I wonder why crc32c isn't used directly while crc32 is used directly
> since they vary by only the polynomial.
It's because iSCSI uses it with scatterlists. The crypto layer
provides a nice interface for that while using it directly would
require the user to do the scatterlist walk.
> Using crc32c directly might enable us to kill net/sctp/crc32c.c and
> merge lib/crc32.c and lib/libcrc32c?
I'm pretty sure we can kill net/sctp/crc32c.c today by converting
it over to use the crypto interface.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fwd: Re: [PATCH] iSCSI fix endieness of digest to be network byte order
2007-11-08 10:40 ` Fwd: Re: [PATCH] iSCSI fix endieness of digest to be network byte order Herbert Xu
@ 2007-11-08 15:47 ` Vlad Yasevich
0 siblings, 0 replies; 2+ messages in thread
From: Vlad Yasevich @ 2007-11-08 15:47 UTC (permalink / raw)
To: Herbert Xu; +Cc: FUJITA Tomonori, bhalevy, linux-crypto, michaelc, netdev
Herbert Xu wrote:
> On Thu, Nov 08, 2007 at 05:04:09PM +0900, FUJITA Tomonori wrote:
>> I wonder why crc32c isn't used directly while crc32 is used directly
>> since they vary by only the polynomial.
>
> It's because iSCSI uses it with scatterlists. The crypto layer
> provides a nice interface for that while using it directly would
> require the user to do the scatterlist walk.
>
>> Using crc32c directly might enable us to kill net/sctp/crc32c.c and
>> merge lib/crc32.c and lib/libcrc32c?
>
> I'm pretty sure we can kill net/sctp/crc32c.c today by converting
> it over to use the crypto interface.
Funny, I looked for crc32c in the lib just the other week and didn't spot
it. Need to look harder :)
-vlad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-08 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <47320C54.10406@panasas.com>
[not found] ` <20071108011849.GA12428@gondor.apana.org.au>
[not found] ` <20071108170409B.fujita.tomonori@lab.ntt.co.jp>
2007-11-08 10:40 ` Fwd: Re: [PATCH] iSCSI fix endieness of digest to be network byte order Herbert Xu
2007-11-08 15:47 ` Vlad Yasevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).