* [PATCH][IPV4] Remove bugus goto-s from ip_route_input_slow
@ 2007-11-10 14:27 Pavel Emelyanov
2007-11-11 5:26 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2007-11-10 14:27 UTC (permalink / raw)
To: David Miller; +Cc: Linux Netdev List, devel
Both places look like
if (err == XXX)
goto yyy;
done:
while both yyy targets look like
err = XXX;
goto done;
so this is ok to remove the above if-s.
yyy labels are used in other places and are not removed.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 21b12de..c95b270 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -1813,11 +1813,6 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
goto martian_destination;
err = ip_mkroute_input(skb, &res, &fl, in_dev, daddr, saddr, tos);
- if (err == -ENOBUFS)
- goto e_nobufs;
- if (err == -EINVAL)
- goto e_inval;
-
done:
in_dev_put(in_dev);
if (free_res)
--
1.5.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][IPV4] Remove bugus goto-s from ip_route_input_slow
2007-11-10 14:27 [PATCH][IPV4] Remove bugus goto-s from ip_route_input_slow Pavel Emelyanov
@ 2007-11-11 5:26 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-11-11 5:26 UTC (permalink / raw)
To: xemul; +Cc: netdev, devel
From: Pavel Emelyanov <xemul@openvz.org>
Date: Sat, 10 Nov 2007 17:27:50 +0300
> Both places look like
>
> if (err == XXX)
> goto yyy;
> done:
>
> while both yyy targets look like
>
> err = XXX;
> goto done;
>
> so this is ok to remove the above if-s.
>
> yyy labels are used in other places and are not removed.
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-11 5:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-10 14:27 [PATCH][IPV4] Remove bugus goto-s from ip_route_input_slow Pavel Emelyanov
2007-11-11 5:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).