From: Pavel Emelyanov <xemul@openvz.org>
To: Simon Horman <horms@verge.net.au>
Cc: David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH 2/2][INET] Move the reqsk_queue_yank_listen_sk from header
Date: Thu, 15 Nov 2007 11:12:33 +0300 [thread overview]
Message-ID: <473BFF71.60501@openvz.org> (raw)
In-Reply-To: <20071115001226.GJ2368@verge.net.au>
Simon Horman wrote:
> On Wed, Nov 14, 2007 at 09:11:06PM +0300, Pavel Emelyanov wrote:
>> This function is used in the net/core/request_sock.c only.
>> No need in keeping it in the header file.
>
> I feel like I am missing something here, but
> doesn't __reqsk_queue_destroy() in include/net/request_sock.h use
> reqsk_queue_yank_listen_sk()?
It does, but this is a patch number 2. The patch number 1 moved this
__reqsk_queue_destroy() into request_sock.c.
> static inline void __reqsk_queue_destroy(struct request_sock_queue
> *queue)
> {
> kfree(reqsk_queue_yank_listen_sk(queue));
> }
Thanks,
Pavel
prev parent reply other threads:[~2007-11-15 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 18:11 [PATCH 2/2][INET] Move the reqsk_queue_yank_listen_sk from header Pavel Emelyanov
2007-11-15 0:12 ` Simon Horman
2007-11-15 8:12 ` Pavel Emelyanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473BFF71.60501@openvz.org \
--to=xemul@openvz.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=horms@verge.net.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).