From: "Denis V. Lunev" <den@sw.ru>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Denis V. Lunev" <den@openvz.org>,
davem@davemloft.net, containers@lists.osdl.org,
netdev@vger.kernel.org, clg@fr.ibm.com, benjamin.thery@bull.net
Subject: Re: [PATCH 2/2] move unneeded data to initdata section
Date: Thu, 15 Nov 2007 17:42:04 +0300 [thread overview]
Message-ID: <473C5ABC.5090204@sw.ru> (raw)
In-Reply-To: <m1abpfy3xz.fsf@ebiederm.dsl.xmission.com>
Eric W. Biederman wrote:
> "Denis V. Lunev" <den@openvz.org> writes:
>
>> This patch reverts Eric's commit 2b008b0a8e96b726c603c5e1a5a7a509b5f61e35
>>
>> It diets .text & .data section of the kernel if CONFIG_NET_NS is not set.
>> This is safe after list operations cleanup.
>
> Ok. This patch is technically safe because none of the touched
> code can live in a module and so we never touch the exit code path.
>
> However in the general case and as a code idiom this __net_initdata
> on struct pernet_operations is fundamentally horribly broken.
>
> Look at what happens if we use this idiom in module. There
> is only one definition of __initdata ".init.data". The module
> loader places all sections that begin with .init in a region of
> memory that will be discarded after module initialization.
nothing is discarded after module load. Though, I can be wrong. Could
you point me to the exact place?
Regards,
Den
next prev parent reply other threads:[~2007-11-15 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 12:01 [PATCH 2/2] move unneeded data to initdata section Denis V. Lunev
2007-11-13 11:24 ` David Miller
2007-11-15 14:32 ` Eric W. Biederman
2007-11-15 14:42 ` Denis V. Lunev [this message]
2007-11-15 15:14 ` Sam Ravnborg
2007-11-15 18:19 ` Eric W. Biederman
2007-11-15 18:43 ` Sam Ravnborg
[not found] ` <20071115184334.GC23914-QabhHTsIXMSnlFQ6Q1D1Y0B+6BGkLq7r@public.gmane.org>
2007-11-15 19:17 ` Denis V. Lunev
2007-11-15 19:34 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473C5ABC.5090204@sw.ru \
--to=den@sw.ru \
--cc=benjamin.thery@bull.net \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).