netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wang Chen <wangchen@cn.fujitsu.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Wang Chen <wangchen@cn.fujitsu.com>
Subject: [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter
Date: Fri, 16 Nov 2007 10:46:26 +0800	[thread overview]
Message-ID: <473D0482.4050705@cn.fujitsu.com> (raw)

Dave, 

The current kernel doesn't verify the udp checksum if user doesn't set a
socket filter.It's fine for LAN. But for WAN, it's not a good option.
Shall we fix it? Below is the patch to make udp checksum be always 
available.

[IPV4] UDP: Always checksum even if without socket filter
Make udp checksum be always available even if without socket filter.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
---
 udp.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

--- linux-2.6.24-rc2.org/net/ipv4/udp.c	2007-11-09 16:37:57.000000000 +0800
+++ linux-2.6.24-rc2/net/ipv4/udp.c	2007-11-16 10:10:35.000000000 +0800
@@ -1011,10 +1011,8 @@ int udp_queue_rcv_skb(struct sock * sk, 
 		}
	}

-	if (sk->sk_filter) {
-		if (udp_lib_checksum_complete(skb))
-			goto drop;
-	}
+	if (udp_lib_checksum_complete(skb))
+		goto drop;

	if ((rc = sock_queue_rcv_skb(sk,skb)) < 0) {
		/* Note that an ENOMEM error is charged twice */


             reply	other threads:[~2007-11-16  2:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-16  2:46 Wang Chen [this message]
2007-11-16  2:54 ` [PATCH 1/2] [IPV4] UDP: Always checksum even if without socket filter David Miller
2007-11-16  3:18   ` Wang Chen
2007-11-16  4:04     ` David Miller
2007-11-16  4:13       ` Wang Chen
2007-11-16 17:02       ` Benny Amorsen
2007-11-16  4:11     ` Herbert Xu
2007-11-16  4:17       ` Wang Chen
2007-11-17 13:18         ` Andi Kleen
2007-11-18  0:09           ` David Miller
2007-11-18 21:45             ` Andi Kleen
2007-11-18 22:40               ` David Miller
2007-11-19  1:09                 ` Herbert Xu
2007-11-19  8:26                   ` David Miller
2007-11-19  2:02                 ` Wang Chen
2007-11-19  8:30                   ` David Miller
2007-11-19  4:41                 ` Herbert Xu
2007-11-19  8:32                   ` David Miller
2007-11-19 11:49                   ` Arnaldo Carvalho de Melo
2007-11-19 15:29                 ` Andi Kleen
2007-11-19 22:23                   ` David Miller
2007-11-20  5:29                     ` Bill Fink
2007-11-20  6:15                       ` David Miller
2007-11-20  6:25                         ` Wang Chen
2007-11-20  6:31                           ` Herbert Xu
2007-11-20 14:05                       ` Andi Kleen
2007-11-21  1:39                         ` David Miller
2007-11-29  7:55                           ` Wang Chen
2007-11-29  9:21                             ` Herbert Xu
2007-11-29 10:08                               ` Wang Chen
2007-11-29 10:21                                 ` Herbert Xu
2007-11-29 10:33                                   ` Wang Chen
2007-11-29 10:38                                     ` Herbert Xu
2007-11-29 10:56                                 ` Gerrit Renker
2007-11-29 12:01                                   ` Herbert Xu
2007-11-18 22:14             ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473D0482.4050705@cn.fujitsu.com \
    --to=wangchen@cn.fujitsu.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).