From: Hideo AOKI <haoki@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, satoshi.oshima.fk@hitachi.com,
billfink@mindspring.com, andi@firstfloor.org,
johnpol@2ka.mipt.ru, shemminger@linux-foundation.org,
yoshfuji@linux-ipv6.org, yumiko.sugita.yf@hitachi.com
Subject: Re: [PATCH 4/5] udp: memory limitation by using udp_mem
Date: Fri, 16 Nov 2007 21:52:16 -0500 [thread overview]
Message-ID: <473E5760.3020802@redhat.com> (raw)
In-Reply-To: <20071116021241.GD32509@gondor.apana.org.au>
Herbert Xu wrote:
> On Thu, Nov 15, 2007 at 03:23:53PM -0800, David Miller wrote:
>> We don't have tests all over the place to see if a socket is TCP or
>> DCCP or SCTP in order to implement memory accounting there, because we
>> did it for connection oriented protocols cleanly, seperating things
>> via callbacks etc.
>>
>> I would like to see the datagram memory accounting work similarly.
>
> I agree. In fact if we adopt some of the conventions used by
> stream protocols such as the use of sk_forward_alloc, we should
> be able to share code with TCP accounting too.
>
> As it is every packet updates a global counter, using sk_forward_alloc
> would mean that for most packets you only update a per-socket counter
> which then would feed into the global counter at points such as socket
> creation and destruction.
>
> Cheers,
Hello,
I appreciate your comments.
I understood that memory accounting code should avoid special protocols checks.
Then, I'll improve this part in next patch set.
Many thanks,
Hideo
--
Hitachi Computer Products (America) Inc.
next prev parent reply other threads:[~2007-11-17 2:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-15 21:44 [PATCH 0/5] UDP memory accounting and limitation (take 8) Hideo AOKI
2007-11-15 21:49 ` [PATCH 1/5] udp: fix send buffer check Hideo AOKI
2007-11-15 21:49 ` [PATCH 2/5] udp: accounting unit and variable Hideo AOKI
2007-11-15 21:50 ` [PATCH 3/5] udp: memory accounting Hideo AOKI
2007-11-15 21:50 ` [PATCH 4/5] udp: memory limitation by using udp_mem Hideo AOKI
2007-11-15 23:23 ` David Miller
2007-11-16 2:12 ` Herbert Xu
2007-11-17 2:52 ` Hideo AOKI [this message]
2007-11-17 4:01 ` David Miller
2007-11-21 23:25 ` Hideo AOKI
2007-11-15 21:50 ` [PATCH 5/5] udp: add udp_rmem_min and udp_wmem_min Hideo AOKI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473E5760.3020802@redhat.com \
--to=haoki@redhat.com \
--cc=andi@firstfloor.org \
--cc=billfink@mindspring.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=johnpol@2ka.mipt.ru \
--cc=netdev@vger.kernel.org \
--cc=satoshi.oshima.fk@hitachi.com \
--cc=shemminger@linux-foundation.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=yumiko.sugita.yf@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).