Re: [PATCH] NET : rt_check_expire() can take a long time, add a cond_resched()

[Eric Dumazet <dada1@cosmosbay.com>]

Andi Kleen a écrit :
> Eric Dumazet <dada1@cosmosbay.com> writes:
> 
>> So it may sound unnecessary but in the rt_check_expire() case, with a
>> loop potentially doing XXX.XXX iterations, being able to bypass the
>> function call is a clear win (in my bench case, 25 ms instead of 88
>> ms). Impact on I-cache is irrelevant here as this rt_check_expires()
> 
> Measuring what? And really milli-seconds? The number does not sound plausible 
> to me.

You know Andi, I have seen production servers that needed several seconds to 
perform the flush. When you have millions of entries on this table, can you 
imagine the number of memory transactions (including atomic ops) needed to 
flush them all ?

The 25.000.000 ns and 88.000.000 ns numbers where on an empty table, but large 
(16 MB of memory)