netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@o2.pl>
To: Bill Fink <billfink@mindspring.com>
Cc: David Miller <davem@davemloft.net>,
	the.sator@gmail.com, kuznet@ms2.inr.ac.ru,
	linux-kernel@vger.kernel.org, jmorris@namei.org,
	netdev@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0
Date: Sat, 17 Nov 2007 23:14:04 +0100	[thread overview]
Message-ID: <473F67AC.5020306@o2.pl> (raw)
In-Reply-To: <20071116142619.8746376e.billfink@mindspring.com>

Bill Fink wrote, On 11/16/2007 08:26 PM:
...

> Regarding the Target IP, RFC 826 says:
> 
> 	"The target protocol address is necessary in the request form
> 	of the packet so that a machine can determine whether or not
> 	to enter the sender information in a table or to send a reply.
> 	It is not necessarily needed in the reply form if one assumes
> 	a reply is only provoked by a request.  It is included for
> 	completeness, network monitoring, and to simplify the suggested
> 	processing algorithm described above (which does not look at
> 	the opcode until AFTER putting the sender information in a
> 	table).
> 
> So it's ambiguous about the target IP address in an ARP reply packet,
> but a value of 0.0.0.0 makes more logical sense to me than using
> 192.168.0.1 in this example case, since it should reflect the requestor
> IP address, which is unknown in this case.

IMHO, you are mostly right, but, according to this, if it's ambiguous
then only, if there is the target IP or no target IP, so here 0.0.0.0
or 0.0.0.0...

Regards,
Jarek P.

  reply	other threads:[~2007-11-17 22:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-15 11:40 [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?) Jonas Danielsson
2007-11-15 15:40 ` Alexey Kuznetsov
2007-11-15 21:40   ` Jonas Danielsson
2007-11-15 23:28     ` [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 David Miller
2007-11-16  8:30       ` Jonas Danielsson
2007-11-16  9:05         ` David Miller
2007-11-16 14:13           ` Benny Amorsen
2007-11-16 19:26           ` Bill Fink
2007-11-17 22:14             ` Jarek Poplawski [this message]
2007-11-19 13:06     ` [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 (was: Strange behavior in arp probe reply, bug or feature?) Alexey Kuznetsov
2007-11-20  5:16       ` Bill Fink
2007-11-20  7:49         ` [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473F67AC.5020306@o2.pl \
    --to=jarkao2@o2.pl \
    --cc=akpm@linux-foundation.org \
    --cc=billfink@mindspring.com \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=the.sator@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).