From: Andrew Morgan <morgan@kernel.org>
To: Kevin Winchester <kjwinchester@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
apw@shadowen.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kamalesh@linux.vnet.ibm.com
Subject: Re: 2.6.24-rc2-mm1 -- strange apparent network failures
Date: Sat, 17 Nov 2007 17:57:22 -0800 [thread overview]
Message-ID: <473F9C02.1040401@kernel.org> (raw)
In-Reply-To: <473F8C46.4070308@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kevin Winchester wrote:
> However, I got around the problem by making the code change manually -
> and my network connection is now working. Looking at the code being
> bypassed:
>
> if (pE.cap[i] || pP.cap[i] || pP.cap[i])
>
> looks somewhat weird as it is testing the same condition twice. Should
> it have been:
>
> if (pE.cap[i] || pP.cap[i] || pI.cap[i])
Yes, that was also a bug. However, upon reflection (and as per my "0 &&"
hack), I now believe these few lines of code are problematic in general.
Thanks for reporting this bug. I'll post a more clear patch (that isn't
GPG'd).
Cheers
Andrew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHP5vy+bHCR3gb8jsRAliTAKCvCsfZuNN7Og57S0s8O4SZNveSUwCgq4VP
vHUE/S+x09l5I24E2/rmLj4=
=JaWT
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2007-11-18 1:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071113175906.497a1a6a.akpm@linux-foundation.org>
2007-11-15 10:02 ` 2.6.24-rc2-mm1 -- strange apparent network failures Andy Whitcroft
2007-11-16 0:28 ` Kevin Winchester
2007-11-16 0:44 ` Andrew Morton
2007-11-17 5:16 ` Andrew Morgan
2007-11-17 12:48 ` Kevin Winchester
2007-11-17 23:52 ` Andrew Morgan
2007-11-18 0:50 ` Kevin Winchester
2007-11-18 1:17 ` Kevin Winchester
2007-11-18 1:57 ` Andrew Morgan [this message]
2007-11-18 1:23 ` Kevin Winchester
2007-11-17 13:57 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473F9C02.1040401@kernel.org \
--to=morgan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).