From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC283C3F2D1 for ; Thu, 5 Mar 2020 22:34:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F23420716 for ; Thu, 5 Mar 2020 22:34:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbgCEWe0 (ORCPT ); Thu, 5 Mar 2020 17:34:26 -0500 Received: from www62.your-server.de ([213.133.104.62]:49510 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbgCEWeZ (ORCPT ); Thu, 5 Mar 2020 17:34:25 -0500 Received: from sslproxy03.your-server.de ([88.198.220.132]) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1j9z4N-0006dU-FQ; Thu, 05 Mar 2020 23:34:19 +0100 Received: from [85.7.42.192] (helo=pc-9.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9z4N-0006hN-60; Thu, 05 Mar 2020 23:34:19 +0100 Subject: Re: [PATCH bpf-next 0/3] Introduce pinnable bpf_link kernel abstraction To: Alexei Starovoitov , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= Cc: Alexei Starovoitov , Andrii Nakryiko , Andrii Nakryiko , bpf , Networking , Kernel Team References: <8083c916-ac2c-8ce0-2286-4ea40578c47f@iogearbox.net> <87pndt4268.fsf@toke.dk> <87k1413whq.fsf@toke.dk> <20200304043643.nqd2kzvabkrzlolh@ast-mbp> <87h7z44l3z.fsf@toke.dk> <20200304154757.3tydkiteg3vekyth@ast-mbp> <874kv33x60.fsf@toke.dk> <20200305163444.6e3w3u3a5ufphwhp@ast-mbp> From: Daniel Borkmann Message-ID: <473a3e8a-03ea-636c-f054-3c960bf0fdbd@iogearbox.net> Date: Thu, 5 Mar 2020 23:34:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20200305163444.6e3w3u3a5ufphwhp@ast-mbp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.2/25742/Thu Mar 5 15:10:18 2020) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/5/20 5:34 PM, Alexei Starovoitov wrote: > On Thu, Mar 05, 2020 at 11:37:11AM +0100, Toke Høiland-Jørgensen wrote: >> Alexei Starovoitov writes: >>> On Wed, Mar 04, 2020 at 08:47:44AM +0100, Toke Høiland-Jørgensen wrote: [...] >> Anyway, what I was trying to express: >> >>> Still that doesn't mean that pinned link is 'immutable'. >> >> I don't mean 'immutable' in the sense that it cannot be removed ever. >> Just that we may end up in a situation where an application can see a >> netdev with an XDP program attached, has the right privileges to modify >> it, but can't because it can't find the pinned bpf_link. Right? Or am I >> misunderstanding your proposal? >> >> Amending my example from before, this could happen by: >> >> 1. Someone attaches a program to eth0, and pins the bpf_link to >> /sys/fs/bpf/myprog >> >> 2. eth0 is moved to a different namespace which mounts a new sysfs at >> /sys >> >> 3. Inside that namespace, /sys/fs/bpf/myprog is no longer accessible, so >> xdp-loader can't get access to the original bpf_link; but the XDP >> program is still attached to eth0. > > The key to decide is whether moving netdev across netns should be allowed > when xdp attached. I think it should be denied. Even when legacy xdp > program is attached, since it will confuse user space managing part. There are perfectly valid use cases where this is done already today (minus bpf_link), for example, consider an orchestrator that is setting up the BPF program on the device, moving to the newly created application pod during the CNI call in k8s, such that the new pod does not have the /sys/fs/bpf/ mount instance and if unprivileged cannot remove the BPF prog from the dev either. We do something like this in case of ipvlan, meaning, we attach a rootlet prog that calls into single slot of a tail call map, move it to the application pod, and only out of Cilium's own pod and it's pod-local bpf fs instance we manage the pinned tail call map to update the main programs in that single slot w/o having to switch any netns later on. Thanks, Daniel