netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver
       [not found] <200711200953.lAK9qxjO030444@imap1.linux-foundation.org>
@ 2007-11-20 13:23 ` Kamalesh Babulal
  2007-11-27  0:59   ` Tony Breeds
  2007-11-20 13:29 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal
  1 sibling, 1 reply; 3+ messages in thread
From: Kamalesh Babulal @ 2007-11-20 13:23 UTC (permalink / raw)
  To: akpm; +Cc: mm-commits, linux-kernel, mick, netdev, Andy Whitcroft,
	Balbir Singh

Hi Andrew,

The kernel build fails, with following message

  LD      drivers/net/wireless/built-in.o
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
(.opd+0x180): multiple definition of `rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple definition of `.rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561: first defined here
ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
(.opd+0x160): multiple definition of `rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:(.opd+0x1d0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:329: multiple definition of `.rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:322: first defined here
ld: Warning: size of symbol `.rtl8225_rf_init' changed from 3492 in drivers/net/wireless/rtl8180.o to 3528 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
(.opd+0x190): multiple definition of `rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:(.opd+0x1c0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:735: multiple definition of `.rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:753: first defined here
ld: Warning: size of symbol `.rtl8225_rf_set_channel' changed from 360 in drivers/net/wireless/rtl8180.o to 136 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
(.opd+0x170): multiple definition of `rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1a0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:719: multiple definition of `.rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:736: first defined here
ld: Warning: size of symbol `.rtl8225_rf_stop' changed from 244 in drivers/net/wireless/rtl8180.o to 632 in drivers/net/wireless/rtl8187.o
make[3]: *** [drivers/net/wireless/built-in.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

The patch causing this build failure, might be git-wireless.patch.

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded
       [not found] <200711200953.lAK9qxjO030444@imap1.linux-foundation.org>
  2007-11-20 13:23 ` mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver Kamalesh Babulal
@ 2007-11-20 13:29 ` Kamalesh Babulal
  1 sibling, 0 replies; 3+ messages in thread
From: Kamalesh Babulal @ 2007-11-20 13:29 UTC (permalink / raw)
  To: akpm
  Cc: mm-commits, linux-kernel, mick, linville, netdev, Andy Whitcroft,
	Balbir Singh

Hi Andrew,

The kernel build fails, with following message

  LD      drivers/net/wireless/built-in.o
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
(.opd+0x180): multiple definition of `rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple definition of `.rtl8225z2_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561: first defined here
ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
(.opd+0x160): multiple definition of `rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:(.opd+0x1d0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:329: multiple definition of `.rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:322: first defined here
ld: Warning: size of symbol `.rtl8225_rf_init' changed from 3492 in drivers/net/wireless/rtl8180.o to 3528 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
(.opd+0x190): multiple definition of `rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:(.opd+0x1c0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_set_channel':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:735: multiple definition of `.rtl8225_rf_set_channel'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:753: first defined here
ld: Warning: size of symbol `.rtl8225_rf_set_channel' changed from 360 in drivers/net/wireless/rtl8180.o to 136 in drivers/net/wireless/rtl8187.o
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_init':
(.opd+0x170): multiple definition of `rtl8225_rf_init'
drivers/net/wireless/rtl8180.o:(.opd+0x1a0): first defined here
drivers/net/wireless/rtl8187.o: In function `rtl8225_rf_stop':
/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:719: multiple definition of `.rtl8225_rf_stop'
drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:736: first defined here
ld: Warning: size of symbol `.rtl8225_rf_stop' changed from 244 in drivers/net/wireless/rtl8180.o to 632 in drivers/net/wireless/rtl8187.o
make[3]: *** [drivers/net/wireless/built-in.o] Error 1
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

The patch causing this build failure, might be git-wireless.patch.
-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver
  2007-11-20 13:23 ` mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver Kamalesh Babulal
@ 2007-11-27  0:59   ` Tony Breeds
  0 siblings, 0 replies; 3+ messages in thread
From: Tony Breeds @ 2007-11-27  0:59 UTC (permalink / raw)
  To: Kamalesh Babulal
  Cc: akpm, mm-commits, linux-kernel, mick, netdev, Andy Whitcroft,
	Balbir Singh, John W. Linville, linux-wireless

On Tue, Nov 20, 2007 at 06:53:15PM +0530, Kamalesh Babulal wrote:
> Hi Andrew,
> 
> The kernel build fails, with following message
> 
>   LD      drivers/net/wireless/built-in.o
> drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
> (.opd+0x180): multiple definition of `rtl8225z2_rf_init'
> drivers/net/wireless/rtl8180.o:(.opd+0x1b0): first defined here
> drivers/net/wireless/rtl8187.o: In function `rtl8225z2_rf_init':
> /root/linux-2.6.24-rc3/drivers/net/wireless/rtl8187_rtl8225.c:571: multiple definition of `.rtl8225z2_rf_init'
> drivers/net/wireless/rtl8180.o:/root/linux-2.6.24-rc3/drivers/net/wireless/rtl8180_rtl8225.c:561: first defined here
> ld: Warning: size of symbol `.rtl8225z2_rf_init' changed from 3836 in drivers/net/wireless/rtl8180.o to 3544 in drivers/net/wireless/rtl8187.o

<snip>

The patch below is a little ugly but will allow allyesconfig to work.  I
don't know enough about the Realtek devices to make intellegent
suggestions on how to fix this particular problem.  Clearly the 2
drivers share a lot of common code so perhaps they can be merged?

I assumed that the RTL8180, is still somewhat WiP based on the commit
message for a2645795713c4374ff2efda960251cdc30b63430 (wireless-2.6.git).

Appologies for the uber long CC line, wasn't sure who can be pruned.

From: Tony Breeds <tony@bakeyournoodle.com>

Temporarily ensure that Realtek 8185 and 8187 aren't compiled together.

These two drivers share a number of common (global) functions.  While RTL8180
is still being worked on ensure that it's not built together with the RTL8187
(ie allyseconfig).

Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>

---

 drivers/net/wireless/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 82e5de7..ab2eac0 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -555,6 +555,7 @@ config USB_ZD1201
 config RTL8180
 	tristate "Realtek 8185 PCI support"
 	depends on MAC80211 && PCI && WLAN_80211 && EXPERIMENTAL
+	depends on !RTL8187
 	select EEPROM_93CX6
 
 config RTL8187

Yours Tony

  linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
  Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-11-27  0:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <200711200953.lAK9qxjO030444@imap1.linux-foundation.org>
2007-11-20 13:23 ` mm snapshot broken-out-2007-11-20-01-45 Build Fail - net/wireless driver Kamalesh Babulal
2007-11-27  0:59   ` Tony Breeds
2007-11-20 13:29 ` mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Kamalesh Babulal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).