* [PATCH][IRDA] Compilation for CONFIG_INET=n case
@ 2007-11-21 16:03 Pavel Emelyanov
2007-11-22 11:18 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Emelyanov @ 2007-11-21 16:03 UTC (permalink / raw)
To: Herbert Xu; +Cc: Samuel Ortiz, Linux Netdev List, devel
Found this occasionally.
The CONFIG_INET=n is hardly ever set, but if it is the
irlan_eth_send_gratuitous_arp() compilation should produce a
warning about unused variable in_dev.
Too pedantic? :)
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/irda/irlan/irlan_eth.c b/net/irda/irlan/irlan_eth.c
index 7f9c854..c682207 100644
--- a/net/irda/irlan/irlan_eth.c
+++ b/net/irda/irlan/irlan_eth.c
@@ -296,6 +296,7 @@ void irlan_eth_flow_indication(void *instance, void *sap, LOCAL_FLOW flow)
*/
void irlan_eth_send_gratuitous_arp(struct net_device *dev)
{
+#ifdef CONFIG_INET
struct in_device *in_dev;
/*
@@ -303,7 +304,6 @@ void irlan_eth_send_gratuitous_arp(struct net_device *dev)
* is useful if we have changed access points on the same
* subnet.
*/
-#ifdef CONFIG_INET
IRDA_DEBUG(4, "IrLAN: Sending gratuitous ARP\n");
rcu_read_lock();
in_dev = __in_dev_get_rcu(dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][IRDA] Compilation for CONFIG_INET=n case
2007-11-21 16:03 [PATCH][IRDA] Compilation for CONFIG_INET=n case Pavel Emelyanov
@ 2007-11-22 11:18 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2007-11-22 11:18 UTC (permalink / raw)
To: Pavel Emelyanov; +Cc: Samuel Ortiz, Linux Netdev List, devel
On Wed, Nov 21, 2007 at 07:03:16PM +0300, Pavel Emelyanov wrote:
> Found this occasionally.
>
> The CONFIG_INET=n is hardly ever set, but if it is the
> irlan_eth_send_gratuitous_arp() compilation should produce a
> warning about unused variable in_dev.
>
> Too pedantic? :)
>
> Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Not too pedantic yet, please keep trying :)
Applied to net-2.6. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-22 11:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-21 16:03 [PATCH][IRDA] Compilation for CONFIG_INET=n case Pavel Emelyanov
2007-11-22 11:18 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).